third_party/WebKit/Source/web/WebSharedWorkerImpl.h - Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)

Patch Set: addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.h

diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

index 85ea4b47391b9cc3b1b259a9b9ddd5cbfb2e2990..886e6bb2fd53757fb4fd2d397f997cf346329c0c 100644

--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

@@ -70,7 +70,7 @@ class WebSharedWorkerImpl final : public WebFrameClient,

explicit WebSharedWorkerImpl(WebSharedWorkerClient*);

// WebFrameClient methods to support resource loading thru the 'shadow page'.

- WebApplicationCacheHost* CreateApplicationCacheHost(

+ std::unique_ptr<WebApplicationCacheHost> CreateApplicationCacheHost(

WebApplicationCacheHostClient*) override;

void DidFinishDocumentLoad(WebLocalFrame*) override;