Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: content/renderer/shared_worker/embedded_shared_worker_stub.h

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/shared_worker/embedded_shared_worker_stub.h
diff --git a/content/renderer/shared_worker/embedded_shared_worker_stub.h b/content/renderer/shared_worker/embedded_shared_worker_stub.h
index 39226b7635cbda3b52e3af72f05c27bb2aecc9e9..e486cbd21e954974585994a022c93774f5bd8399 100644
--- a/content/renderer/shared_worker/embedded_shared_worker_stub.h
+++ b/content/renderer/shared_worker/embedded_shared_worker_stub.h
@@ -68,13 +68,13 @@ class EmbeddedSharedWorkerStub : public IPC::Listener,
void WorkerScriptLoadFailed() override;
void SelectAppCacheID(long long) override;
blink::WebNotificationPresenter* NotificationPresenter() override;
- blink::WebApplicationCacheHost* CreateApplicationCacheHost(
+ std::unique_ptr<blink::WebApplicationCacheHost> CreateApplicationCacheHost(
blink::WebApplicationCacheHostClient*) override;
blink::WebWorkerContentSettingsClientProxy*
CreateWorkerContentSettingsClientProxy(
const blink::WebSecurityOrigin& origin) override;
- blink::WebServiceWorkerNetworkProvider* CreateServiceWorkerNetworkProvider()
- override;
+ std::unique_ptr<blink::WebServiceWorkerNetworkProvider>
+ CreateServiceWorkerNetworkProvider() override;
void SendDevToolsMessage(int session_id,
int call_id,
const blink::WebString& message,
@@ -110,7 +110,7 @@ class EmbeddedSharedWorkerStub : public IPC::Listener,
std::vector<PendingChannel> pending_channels_;
ScopedChildProcessReference process_ref_;
- WebApplicationCacheHostImpl* app_cache_host_ = nullptr;
+ WebApplicationCacheHostImpl* app_cache_host_ = nullptr; // Not owned.
DISALLOW_COPY_AND_ASSIGN(EmbeddedSharedWorkerStub);
};

Powered by Google App Engine
This is Rietveld 408576698