Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index 1a90bcbfab8f4aae61c3dbe8c6ddaad0eef7972b..cd405beba518b932d17bed0f42509b86d00a3f66 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -47,6 +47,7 @@
#include "WebSandboxFlags.h"
#include "WebTextDirection.h"
#include "public/platform/BlameContext.h"
+#include "public/platform/WebApplicationCacheHost.h"
#include "public/platform/WebColor.h"
#include "public/platform/WebCommon.h"
#include "public/platform/WebContentSecurityPolicy.h"
@@ -66,6 +67,7 @@
#include "public/platform/WebURLError.h"
#include "public/platform/WebURLRequest.h"
#include "public/platform/WebWorkerFetchContext.h"
+#include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h"
#include "v8/include/v8.h"
namespace blink {
@@ -133,13 +135,16 @@ class BLINK_EXPORT WebFrameClient {
virtual WebMediaSession* CreateMediaSession() { return 0; }
// May return null.
- virtual WebApplicationCacheHost* CreateApplicationCacheHost(
+ virtual std::unique_ptr<WebApplicationCacheHost> CreateApplicationCacheHost(
WebApplicationCacheHostClient*) {
- return 0;
+ return nullptr;
}
// May return null.
- virtual WebServiceWorkerProvider* CreateServiceWorkerProvider() { return 0; }
+ virtual std::unique_ptr<WebServiceWorkerProvider>
+ CreateServiceWorkerProvider() {
+ return nullptr;
+ }
// May return null.
virtual WebWorkerContentSettingsClientProxy*
« no previous file with comments | « third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp ('k') | third_party/WebKit/public/web/WebSharedWorkerClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698