Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index b25f19517081fa60d9ebb16ab02c4043b55d56c7..430b6f5583043e62a6681d58d4ebb82e3840c75a 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -1063,7 +1063,7 @@ void ServiceWorkerContextClient::DidHandlePaymentRequestEvent(
context_->payment_request_event_callbacks.erase(payment_request_id);
}
-blink::WebServiceWorkerNetworkProvider*
+std::unique_ptr<blink::WebServiceWorkerNetworkProvider>
ServiceWorkerContextClient::CreateServiceWorkerNetworkProvider() {
DCHECK(main_thread_task_runner_->RunsTasksOnCurrentThread());
@@ -1081,7 +1081,8 @@ ServiceWorkerContextClient::CreateServiceWorkerNetworkProvider() {
embedded_worker_id_);
// Blink is responsible for deleting the returned object.
- return new WebServiceWorkerNetworkProviderImpl(std::move(provider));
+ return base::MakeUnique<WebServiceWorkerNetworkProviderImpl>(
+ std::move(provider));
}
std::unique_ptr<blink::WebWorkerFetchContext>
@@ -1099,13 +1100,13 @@ ServiceWorkerContextClient::CreateServiceWorkerFetchContext() {
worker_url_loader_factory_provider.PassInterface(), network_provider_id_);
}
-blink::WebServiceWorkerProvider*
+std::unique_ptr<blink::WebServiceWorkerProvider>
ServiceWorkerContextClient::CreateServiceWorkerProvider() {
DCHECK(main_thread_task_runner_->RunsTasksOnCurrentThread());
DCHECK(provider_context_);
// Blink is responsible for deleting the returned object.
- return new WebServiceWorkerProviderImpl(
+ return base::MakeUnique<WebServiceWorkerProviderImpl>(
sender_.get(), provider_context_.get());
}

Powered by Google App Engine
This is Rietveld 408576698