Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.
Therefore, this CL moved it from Worklet to ThreadedWorklet.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
Review-Url: https://codereview.chromium.org/2845533002
Cr-Commit-Position: refs/heads/master@{#467300}
Committed: https://chromium.googlesource.com/chromium/src/+/f2c7bd6ebff851528ab06aa8ff14a964e3437df0

[nhiroki, 2017-04-26 08:01:29]

Description was changed from

==========
Worklet: Move Worklet::Initialization() into ThreadedWorklet

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialization() is called when addModule() is called for the first
time and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

[nhiroki, 2017-04-26 08:02:35]

Description was changed from

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

[nhiroki, 2017-04-26 08:03:29]

Description was changed from

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for clean up

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

[nhiroki, 2017-04-26 08:06:45]

Description was changed from

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for clean up

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for clean up

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
==========

[nhiroki, 2017-04-26 08:07:43]

Description was changed from

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for clean up

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
==========

[nhiroki, 2017-04-26 08:08:17]

Description was changed from

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.
Therefore, this CL moved it from Worklet to ThreadedWorklet.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
==========

[nhiroki, 2017-04-26 08:08:45]

nhiroki@chromium.org changed reviewers:
+ kouhei@chromium.org

[nhiroki, 2017-04-26 08:08:45]

PTAL, thanks!

[nhiroki, 2017-04-26 08:08:51]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 08:09:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 09:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 09:12:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2017-04-26 09:23:59]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 09:24:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2017-04-26 10:47:37]

https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorklet.h (right):

https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorklet.h:33: virtual void
Initialize() = 0;
Can we rename Initialize method to more descriptive name?
Suggestion: InitializeBackingThreadAndProxy()

[nhiroki, 2017-04-26 11:01:47]

Thank you.

https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/ThreadedWorklet.h (right):

https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/ThreadedWorklet.h:33: virtual void
Initialize() = 0;
On 2017/04/26 10:47:37, kouhei wrote:
> Can we rename Initialize method to more descriptive name?
> Suggestion: InitializeBackingThreadAndProxy()

SG. Let me rename this in a separate CL because it requires wider changes
(including AnimationWorklet, CompositorWorklet and AudioWorklet)

[kouhei (in TOK), 2017-04-26 11:06:48]

On 2017/04/26 11:01:47, nhiroki wrote:
> Thank you.
> 
>
https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/workers/ThreadedWorklet.h (right):
> 
>
https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/workers/ThreadedWorklet.h:33: virtual void
> Initialize() = 0;
> On 2017/04/26 10:47:37, kouhei wrote:
> > Can we rename Initialize method to more descriptive name?
> > Suggestion: InitializeBackingThreadAndProxy()
> 
> SG. Let me rename this in a separate CL because it requires wider changes
> (including AnimationWorklet, CompositorWorklet and AudioWorklet)

ok. lgtm for this CL

[commit-bot: I haz the power, 2017-04-26 11:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 11:15:03]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-26 11:47:34]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-04-26 11:47:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 11:52:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493207254804460,
"parent_rev": "faa055103d806be6bcdb05b721c954d1b1584200", "commit_rev":
"f2c7bd6ebff851528ab06aa8ff14a964e3437df0"}

[commit-bot: I haz the power, 2017-04-26 11:52:18]

Description was changed from

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.
Therefore, this CL moved it from Worklet to ThreadedWorklet.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945
==========

to

==========
Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

This is split from https://codereview.chromium.org/2840523002/

Worklet::Initialize() is called when addModule() is called for the first time,
and expected to initialize a messaging proxy and a worklet thread. This is
used only for threaded worklets, and not necessary for main thread worklets.
Therefore, this CL moved it from Worklet to ThreadedWorklet.

Motivation of this change: MainThreadWorklet will have a separate initialization
logic after the above CL and the similar initialization function will be an
obstacle.

BUG=627945

Review-Url: https://codereview.chromium.org/2845533002
Cr-Commit-Position: refs/heads/master@{#467300}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2c7bd6ebff851528ab06aa8ff14...
==========

[commit-bot: I haz the power, 2017-04-26 11:52:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2c7bd6ebff851528ab06aa8ff14...