Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp

Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup (Closed)
Patch Set: fix test failures Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp
diff --git a/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp b/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp
index 1c7e06f83015b15769eed29befdbf54df2911f3f..b3ffe3bec9481ff04fadb12b4fb0ac8651013d69 100644
--- a/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp
+++ b/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp
@@ -46,9 +46,6 @@ ScriptPromise MainThreadWorklet::addModule(ScriptState* script_state,
kSyntaxError, "'" + url + "' is not a valid URL."));
}
- if (!IsInitialized())
- Initialize();
-
int32_t request_id = GetNextRequestId();
ScriptPromiseResolver* resolver = ScriptPromiseResolver::Create(script_state);
ScriptPromise promise = resolver->Promise();
@@ -74,6 +71,7 @@ void MainThreadWorklet::DidFetchAndInvokeScript(int32_t request_id,
void MainThreadWorklet::ContextDestroyed(ExecutionContext* execution_context) {
DCHECK(IsMainThread());
resolver_map_.clear();
+ GetWorkletGlobalScopeProxy()->TerminateWorkletGlobalScope();
Worklet::ContextDestroyed(execution_context);
}

Powered by Google App Engine
This is Rietveld 408576698