third_party/WebKit/Source/core/workers/Worklet.h - Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/Worklet.h

Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup (Closed)

Patch Set: fix test failures Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/Worklet.h

diff --git a/third_party/WebKit/Source/core/workers/Worklet.h b/third_party/WebKit/Source/core/workers/Worklet.h

index 07122bda3c915bba916cf1c790d422169b002349..9d00d522741a39f7107e42e0c7465a994fd0f210 100644

--- a/third_party/WebKit/Source/core/workers/Worklet.h

+++ b/third_party/WebKit/Source/core/workers/Worklet.h

@@ -30,9 +30,6 @@ class CORE_EXPORT Worklet : public GarbageCollectedFinalized<Worklet>,

public:

virtual ~Worklet() = default;

- virtual void Initialize() {}

- virtual bool IsInitialized() const { return true; }

// Worklet.idl

// addModule() imports ES6 module scripts.

virtual ScriptPromise addModule(ScriptState*, const String& url) = 0;