Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup (Closed)

Created:
2 years, 1 month ago by nhiroki
Modified:
2 years, 1 month ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup This is split from https://codereview.chromium.org/2840523002/ Worklet::Initialize() is called when addModule() is called for the first time, and expected to initialize a messaging proxy and a worklet thread. This is used only for threaded worklets, and not necessary for main thread worklets. Therefore, this CL moved it from Worklet to ThreadedWorklet. Motivation of this change: MainThreadWorklet will have a separate initialization logic after the above CL and the similar initialization function will be an obstacle. BUG=627945 Review-Url: https://codereview.chromium.org/2845533002 Cr-Commit-Position: refs/heads/master@{#467300} Committed: https://chromium.googlesource.com/chromium/src/+/f2c7bd6ebff851528ab06aa8ff14a964e3437df0

Patch Set 1 #

Patch Set 2 : fix test failures #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorklet.h View 1 chunk +4 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
nhiroki
PTAL, thanks!
2 years, 1 month ago (2017-04-26 08:08:45 UTC) #8
kouhei (in TOK)
https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Source/core/workers/ThreadedWorklet.h File third_party/WebKit/Source/core/workers/ThreadedWorklet.h (right): https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Source/core/workers/ThreadedWorklet.h#newcode33 third_party/WebKit/Source/core/workers/ThreadedWorklet.h:33: virtual void Initialize() = 0; Can we rename Initialize ...
2 years, 1 month ago (2017-04-26 10:47:37 UTC) #15
nhiroki
Thank you. https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Source/core/workers/ThreadedWorklet.h File third_party/WebKit/Source/core/workers/ThreadedWorklet.h (right): https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Source/core/workers/ThreadedWorklet.h#newcode33 third_party/WebKit/Source/core/workers/ThreadedWorklet.h:33: virtual void Initialize() = 0; On 2017/04/26 ...
2 years, 1 month ago (2017-04-26 11:01:47 UTC) #16
kouhei (in TOK)
On 2017/04/26 11:01:47, nhiroki wrote: > Thank you. > > https://codereview.chromium.org/2845533002/diff/20001/third_party/WebKit/Source/core/workers/ThreadedWorklet.h > File third_party/WebKit/Source/core/workers/ThreadedWorklet.h (right): ...
2 years, 1 month ago (2017-04-26 11:06:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845533002/20001
2 years, 1 month ago (2017-04-26 11:47:57 UTC) #21
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 11:52:19 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2c7bd6ebff851528ab06aa8ff14...

Powered by Google App Engine
This is Rietveld 408576698