Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorklet.h

Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup (Closed)
Patch Set: fix test failures Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/ThreadedWorklet.h
diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorklet.h b/third_party/WebKit/Source/core/workers/ThreadedWorklet.h
index bb418d1ba039784b3c7feb310c1bdbbc179e78fe..4c4d92d1252ce877dbf5e53a1e6dc810da92967b 100644
--- a/third_party/WebKit/Source/core/workers/ThreadedWorklet.h
+++ b/third_party/WebKit/Source/core/workers/ThreadedWorklet.h
@@ -29,6 +29,10 @@ class CORE_EXPORT ThreadedWorklet : public Worklet,
public:
virtual ~ThreadedWorklet() = default;
+ // Called when addModule() is called for the first time.
+ virtual void Initialize() = 0;
kouhei (in TOK) 2017/04/26 10:47:37 Can we rename Initialize method to more descriptiv
nhiroki 2017/04/26 11:01:46 SG. Let me rename this in a separate CL because it
+ virtual bool IsInitialized() const = 0;
+
// Worklet
ScriptPromise addModule(ScriptState*, const String& url) final;

Powered by Google App Engine
This is Rietveld 408576698