third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp - Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp

Issue 2845533002: Worklet: Move Worklet::Initialize() into ThreadedWorklet for cleanup (Closed)

Patch Set: fix test failures Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp

index ff5d4db291159872008199fb5ecb27439f1b9ad5..21b26cfe696d0f87ebdb3f833e741ddd89e6c6a1 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp

@@ -67,6 +67,8 @@ void ThreadedWorklet::ContextDestroyed(ExecutionContext* execution_context) {

for (const auto& script_loader : loader_to_resolver_map_.Keys())

script_loader->Cancel();

loader_to_resolver_map_.clear();

+ if (IsInitialized())

+ GetWorkletGlobalScopeProxy()->TerminateWorkletGlobalScope();

Worklet::ContextDestroyed(execution_context);

}