Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(107)

Issue 2840523002: [DONT COMMIT] Worklet: Implement "addModule()" algorithm for main thread worklets (Closed)

Created:
2 years, 3 months ago by nhiroki
Modified:
2 years, 3 months ago
CC:
chromium-reviews, shimazu+worker_chromium.org, haraken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Implement "addModule()" algorithm for main thread worklets This CL implements "addModule()" algorithm[1] for main thread worklets and enables a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows: Before this CL: - MainThreadWorklet directly owns *one* MainThreadWorkletGlobalScope. After this CL: - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's. - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope. Note that this still uses classic script loading. Following CLs will implement module script loading. [1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule BUG=627945

Patch Set 1 #

Total comments: 13

Patch Set 2 : fix layout test failures (not address review comments yet) #

Patch Set 3 : rebase #

Patch Set 4 : remake (still wip) #

Patch Set 5 : rebase on https://codereview.chromium.org/2839123003/ #

Patch Set 6 : rebase #

Patch Set 7 : rebase on https://codereview.chromium.org/2851693002/ #

Patch Set 8 : rebase #

Messages

Total messages: 46 (43 generated)
nhiroki
PTAL, thanks! https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp File third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp (right): https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp#newcode30 third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp:30: return definition; ikilpatrick@: I'm not sure how ...
2 years, 3 months ago (2017-04-25 09:31:33 UTC) #28
kouhei (in TOK)
https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp File third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp (right): https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp#newcode31 third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:31: struct MainThreadWorklet::PendingTasks : public GarbageCollected<PendingTasks> { please make this ...
2 years, 3 months ago (2017-04-25 11:55:18 UTC) #33
nhiroki
2 years, 3 months ago (2017-05-09 01:08:45 UTC) #46
Let me close this review because most of changes in this CL (w/ addressing
kouhei@'s comments) were landed by separate CLs and the last part is now under
review here: https://codereview.chromium.org/2871513002/

Powered by Google App Engine
This is Rietveld 408576698