[DONT COMMIT] Worklet: Implement "addModule()" algorithm for main thread worklets

Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm[1] for main thread worklets and
enables a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as
follows:

Before this CL:
  - MainThreadWorklet directly owns *one* MainThreadWorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses classic script loading. Following CLs will implement
module script loading.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945

[nhiroki, 2017-04-25 02:27:34]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 02:27:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 02:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 02:31:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2017-04-25 08:49:53]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 08:50:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-25 08:56:58]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 08:57:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-25 09:10:15]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm

https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets. Especially,
to improve the spec compatibility, this changes the way to manage worklet global
scopes as follows:

Before this CL:
  - MainThreadWorklet owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalProxy's.
  - Each WorkletGlobalProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:11:02]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets. Especially,
to improve the spec compatibility, this changes the way to manage worklet global
scopes as follows:

Before this CL:
  - MainThreadWorklet owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalProxy's.
  - Each WorkletGlobalProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets. Especially,
to improve the spec compatibility, this changes the way to manage worklet global
scopes as follows:

Before this CL:
  - MainThreadWorklet owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalProxy's.
  - Each WorkletGlobalProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:11:37]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets. Especially,
to improve the spec compatibility, this changes the way to manage worklet global
scopes as follows:

Before this CL:
  - MainThreadWorklet owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalProxy's.
  - Each WorkletGlobalProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets. Especially,
to improve the spec compatibility, this changes the way to manage worklet global
scopes as follows:

Before this CL:
  - MainThreadWorklet owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:13:19]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 09:13:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-25 09:21:29]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets. Especially,
to improve the spec compatibility, this changes the way to manage worklet global
scopes as follows:

Before this CL:
  - MainThreadWorklet owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:22:24]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-04-25 09:22:34]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 09:22:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-25 09:23:11]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:23:21]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGloablScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:23:29]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2017-04-25 09:23:37]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2017-04-25 09:23:44]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2017-04-25 09:23:53]

Patchset #1 (id:80001) has been deleted

[nhiroki, 2017-04-25 09:24:01]

Patchset #1 (id:100001) has been deleted

[nhiroki, 2017-04-25 09:30:34]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses the classic script loading. Following CLs will
implement it.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:31:00]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses the classic script loading. Following CLs will
implement it.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses classic script loading. Following CLs will implement
module script loading.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:31:31]

nhiroki@chromium.org changed reviewers:
+ ikilpatrick@chromium.org, kouhei@chromium.org

[nhiroki, 2017-04-25 09:31:33]

PTAL, thanks!

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp (right):

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp:30: return
definition;
ikilpatrick@: I'm not sure how FindDefinition() should work with multiple global
scopes. Is this correct?

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp:40:
global_scope->AddPendingGenerator(name, generator);
ikilpatrick@: ditto. Is it right to call this function on all global scopes?

[nhiroki, 2017-04-25 09:32:04]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm for main thread worklets and enables
a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses classic script loading. Following CLs will implement
module script loading.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm[1] for main thread worklets and
enables a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as
follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses classic script loading. Following CLs will implement
module script loading.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[nhiroki, 2017-04-25 09:32:29]

Description was changed from

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm[1] for main thread worklets and
enables a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as
follows:

Before this CL:
  - MainThreadWorklet directly owns *one* WorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses classic script loading. Following CLs will implement
module script loading.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

to

==========
Worklet: Implement "addModule()" algorithm for main thread worklets

This CL implements "addModule()" algorithm[1] for main thread worklets and
enables a MainThreadWorklet to host multiple MainThreadWorkletGlobalScopes as
follows:

Before this CL:
  - MainThreadWorklet directly owns *one* MainThreadWorkletGlobalScope.

After this CL:
  - MainThreadWorklet owns a map of WorkletGlobalScopeProxy's.
  - Each WorkletGlobalScopeProxy owns a MainThreadWorkletGlobalScope.

Note that this still uses classic script loading. Following CLs will implement
module script loading.

[1] https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule

BUG=627945
==========

[commit-bot: I haz the power, 2017-04-25 10:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 10:29:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kouhei (in TOK), 2017-04-25 11:55:18]

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp (right):

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:31: struct
MainThreadWorklet::PendingTasks : public GarbageCollected<PendingTasks> {
please make this a proper class

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:45:
DCHECK(pending_tasks_map_.IsEmpty());
I think we can safely omit this DCHECK.

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:52:
DCHECK(IsMainThread());
Optional: I'd prefer to have all the steps in the algorithm listed.

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:59: // Step 4: "If
moduleURLRecord is failure, then reject promise with a
Can we rename the script_url var to module_url_record? and url -> module_url?

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:61: KURL script_url
= GetExecutionContext()->CompleteURL(url);
Looks like CompleteURL part is the Step 3?

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:71: //         
moduleResponsesMap, and outsideSettings."
Add TODO(nhiroki) comment about the workletGlobalScopeType, moduleResponsesMap,
and outsideSettings

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:102: PendingTasks*
pending_tasks = pending_tasks_map_.at(request_id);
Optional: map_.Find here to get iterator

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:107: // responsible
event loop to run these steps:"
Add TODO(nhiroki) or add note to justify not queuing a task?

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:110:
pending_tasks_map_.erase(request_id);
and trigger erase on the iterator?

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp:117: // these
steps:"
Ditto.

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorklet.h (right):

https://codereview.chromium.org/2840523002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorklet.h:48: // "A Worklet has
a list of the worklet's WorkletGlobalScopes. Initially this
Provide link to the spec

[nhiroki, 2017-04-25 13:04:58]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 13:05:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 14:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:44:21]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-27 01:04:04]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 01:05:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:14:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 04:14:19]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-28 07:04:48]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 07:05:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-04-28 07:22:18]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 07:22:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-05-09 01:08:45]

Let me close this review because most of changes in this CL (w/ addressing
kouhei@'s comments) were landed by separate CLs and the last part is now under
review here: https://codereview.chromium.org/2871513002/