|
Rename card 'type' into 'issuer network.'
Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:
1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.
The catalog of renames:
----------------------------------------------------------
| BEFORE | AFTER |
----------------------------------------------------------
| AcceptedCardTypes | AcceptedIssuerNetworks |
| basic_card_payment_type | basic_card_issuer_network |
| BasicCardPaymentType | BasicCardIssuerNetwork |
| "card type" | "card issuer network" |
| CardTypeInfo | CardIssuerNetwork |
| card_type | issuer_network |
| CardTypes | CardIssuerNetworks |
| CreditCardType | CardNetwork |
| CreditCard::type | CreditCard::network |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits | NetworkAndLastFourDigits |
| TypeForDisplay | NetworkForDisplay |
| TypeForFill | NetworkForFill |
| TypeForMaskedCard | NetworkForMaskedCard |
| CardTypeForBasicCardPaymentType | |
| | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------
Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
anywhere.
BUG= 602665
Review-Url: https://codereview.chromium.org/2844463004
Cr-Commit-Position: refs/heads/master@{#468350}
Committed: https://chromium.googlesource.com/chromium/src/+/4e981bd3206d558e19b9dd04ef9c83bd2ccb6b0f
Total comments: 11
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1585 lines, -1519 lines) |
Patch |
|
M |
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
|
View
|
|
9 chunks |
+15 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
|
View
|
|
11 chunks |
+63 lines, -55 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/android/personal_data_manager_android.h
|
View
|
|
2 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/autofill/android/personal_data_manager_android.cc
|
View
|
|
5 chunks |
+13 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm
|
View
|
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/autofill/save_card_bubble_views.cc
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
|
View
|
|
3 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_data_util.h
|
View
|
|
3 chunks |
+12 lines, -8 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_data_util.cc
|
View
|
1
2
3
4
|
3 chunks |
+18 lines, -16 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_manager.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_manager_unittest.cc
|
View
|
1
2
3
|
63 chunks |
+197 lines, -192 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_metrics_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
D |
components/autofill/core/browser/autofill_sync_constants.h
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
|
D |
components/autofill/core/browser/autofill_sync_constants.cc
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_test_utils.cc
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/credit_card.h
|
View
|
|
11 chunks |
+46 lines, -42 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/credit_card.cc
|
View
|
|
14 chunks |
+45 lines, -44 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/credit_card_unittest.cc
|
View
|
|
6 chunks |
+190 lines, -190 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/personal_data_manager.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/personal_data_manager.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/personal_data_manager_unittest.cc
|
View
|
1
2
3
4
|
59 chunks |
+569 lines, -561 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
|
View
|
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/validation.h
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/validation.cc
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/webdata/autofill_table.h
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/webdata/autofill_table.cc
|
View
|
1
2
3
4
5
|
56 chunks |
+212 lines, -204 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/webdata/autofill_table_unittest.cc
|
View
|
|
6 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/ios/browser/credit_card_util.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/payments/content/payment_request_state.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/payments/core/autofill_payment_instrument.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/test/data/web_database/version_70.sql
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A + |
components/test/data/web_database/version_71.sql
|
View
|
|
2 chunks |
+11 lines, -14 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/BUILD.gn
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/web_database.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/web_database.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/web_database_migration_unittest.cc
|
View
|
|
2 chunks |
+50 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/web_database_table.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/payments/payment_request.mm
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm
|
View
|
1
2
3
4
|
4 chunks |
+22 lines, -21 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/payments/payment_request_coordinator.mm
|
View
|
1
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/payments/payment_request_view_controller.mm
|
View
|
1
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
|
View
|
1
2
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
Total messages: 81 (60 generated)
|