Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, rogerm+autofillwatch_chromium.org, browser-components-watch_chromium.org, noyau+watch_chromium.org, agrieve+watch_chromium.org, marq+watch_chromium.org, ios-reviews_chromium.org, sebsg+autofillwatch_chromium.org, jam, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+autofill_chromium.org, rouslan+payments_chromium.org, sdefresne+watch_chromium.org, mathp+autofillwatch_chromium.org, tfarina, pkl (ping after 24h if needed), mac-reviews_chromium.org, mahmadi+paymentswatch_chromium.org, estade+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename card 'type' into 'issuer network.' Autofill and payments code is using the word 'type' to mean 'issuer network,' e.g., Visa, MasterCard, AmEx. In order to differentiate between credit/debit/prepaid card types in an upcoming patch, the current instances of the word 'type' need to be renamed to 'issuer network.' The changes are in: 1) Autofill table. 2) Method names. 3) Variable names. 4) Comments. The catalog of renames: ---------------------------------------------------------- | BEFORE | AFTER | ---------------------------------------------------------- | AcceptedCardTypes | AcceptedIssuerNetworks | | basic_card_payment_type | basic_card_issuer_network | | BasicCardPaymentType | BasicCardIssuerNetwork | | "card type" | "card issuer network" | | CardTypeInfo | CardIssuerNetwork | | card_type | issuer_network | | CardTypes | CardIssuerNetworks | | CreditCardType | CardNetwork | | CreditCard::type | CreditCard::network | | masked_credit_cards.type | masked_credit_cards.network | | TypeAndLastFourDigits | NetworkAndLastFourDigits | | TypeForDisplay | NetworkForDisplay | | TypeForFill | NetworkForFill | | TypeForMaskedCard | NetworkForMaskedCard | | CardTypeForBasicCardPaymentType | | | | IssuerNetworkForBasicCardIssuerNetwork | ---------------------------------------------------------- Bonus: * This patch has been run through `git cl lint` and `git cl format` to improve the code quality of the affected files. * autofill_sync_constants have been removed because they were not used anywhere. BUG=602665 Review-Url: https://codereview.chromium.org/2844463004 Cr-Commit-Position: refs/heads/master@{#468350} Committed: https://chromium.googlesource.com/chromium/src/+/4e981bd3206d558e19b9dd04ef9c83bd2ccb6b0f

Patch Set 1 #

Patch Set 2 : Fix iOS compile #

Patch Set 3 : More iOS compile fix #

Total comments: 11

Patch Set 4 : Fix Android compile #

Patch Set 5 : Peter's comments #

Patch Set 6 : Update compatible version #

Total comments: 2

Patch Set 7 : read -> use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1585 lines, -1519 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 9 chunks +15 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 11 chunks +63 lines, -55 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/autofill/save_card_bubble_views.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.h View 3 chunks +12 lines, -8 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.cc View 1 2 3 4 3 chunks +18 lines, -16 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 63 chunks +197 lines, -192 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/autofill/core/browser/autofill_sync_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/autofill/core/browser/autofill_sync_constants.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/credit_card.h View 11 chunks +46 lines, -42 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 14 chunks +45 lines, -44 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 6 chunks +190 lines, -190 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 4 59 chunks +569 lines, -561 lines 0 comments Download
M components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/validation.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 2 3 4 5 56 chunks +212 lines, -204 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/ios/browser/credit_card_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_request_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/core/autofill_payment_instrument.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/test/data/web_database/version_70.sql View 1 chunk +1 line, -1 line 0 comments Download
A + components/test/data/web_database/version_71.sql View 2 chunks +11 lines, -14 lines 0 comments Download
M components/webdata/common/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_database.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_database.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +50 lines, -5 lines 0 comments Download
M components/webdata/common/web_database_table.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm View 1 2 3 4 4 chunks +22 lines, -21 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator.mm View 1 1 chunk +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_view_controller.mm View 1 1 chunk +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 81 (60 generated)
please use gerrit instead
Mathieu, PTAL overall. Sorry for the huuuuuuuge patch!
3 years, 8 months ago (2017-04-25 20:54:57 UTC) #24
please use gerrit instead
Peter, ptal components/webdata/ and autofill_table*.
3 years, 8 months ago (2017-04-25 21:21:47 UTC) #32
please use gerrit instead
Max, ptal single_client_wallet_sync_test.cc.
3 years, 8 months ago (2017-04-25 21:23:39 UTC) #34
please use gerrit instead
Miguel, ptal chrome/android/java/src/org/chromium/chrome/browser/preferences/. Moe, ptal ios/.
3 years, 8 months ago (2017-04-25 21:25:55 UTC) #36
please use gerrit instead
Louis, ptal ios/chrome/browser/ui/settings/.
3 years, 8 months ago (2017-04-25 21:27:17 UTC) #38
maxbogue
single_client_wallet_sync_test.cc lgtm
3 years, 8 months ago (2017-04-25 21:32:27 UTC) #41
lpromero
ios/.../settings lgtm
3 years, 8 months ago (2017-04-25 22:01:07 UTC) #43
Mathieu
lgtm
3 years, 8 months ago (2017-04-26 00:23:51 UTC) #50
Peter Kasting
https://codereview.chromium.org/2844463004/diff/120001/components/autofill/core/browser/webdata/autofill_table.cc File components/autofill/core/browser/webdata/autofill_table.cc (right): https://codereview.chromium.org/2844463004/diff/120001/components/autofill/core/browser/webdata/autofill_table.cc#newcode53 components/autofill/core/browser/webdata/autofill_table.cc:53: using ::base::TimeDelta; Nit: Any particular reason to move these? ...
3 years, 8 months ago (2017-04-26 01:27:28 UTC) #51
please use gerrit instead
Peter, can you explain what the compatible version number does? It sounds like it might ...
3 years, 8 months ago (2017-04-26 16:34:15 UTC) #54
Peter Kasting
https://codereview.chromium.org/2844463004/diff/120001/components/autofill/core/browser/webdata/autofill_table.cc File components/autofill/core/browser/webdata/autofill_table.cc (right): https://codereview.chromium.org/2844463004/diff/120001/components/autofill/core/browser/webdata/autofill_table.cc#newcode486 components/autofill/core/browser/webdata/autofill_table.cc:486: *update_compatible_version = false; On 2017/04/26 16:34:15, ಠ_ಠ wrote: > ...
3 years, 8 months ago (2017-04-26 17:47:56 UTC) #55
please use gerrit instead
Peter, ptal patch 6. I've expanded the comment for the meaning of the |update_compatible_version| variable, ...
3 years, 8 months ago (2017-04-26 18:33:21 UTC) #60
Peter Kasting
LGTM! Thanks for the comment update, it helps. https://codereview.chromium.org/2844463004/diff/180001/components/webdata/common/web_database_table.h File components/webdata/common/web_database_table.h (right): https://codereview.chromium.org/2844463004/diff/180001/components/webdata/common/web_database_table.h#newcode52 components/webdata/common/web_database_table.h:52: // ...
3 years, 8 months ago (2017-04-26 18:35:53 UTC) #61
please use gerrit instead
https://codereview.chromium.org/2844463004/diff/180001/components/webdata/common/web_database_table.h File components/webdata/common/web_database_table.h (right): https://codereview.chromium.org/2844463004/diff/180001/components/webdata/common/web_database_table.h#newcode52 components/webdata/common/web_database_table.h:52: // break previous versions when they try to read ...
3 years, 8 months ago (2017-04-26 18:37:16 UTC) #62
Moe
On 2017/04/26 18:37:16, ಠ_ಠ wrote: > https://codereview.chromium.org/2844463004/diff/180001/components/webdata/common/web_database_table.h > File components/webdata/common/web_database_table.h (right): > > https://codereview.chromium.org/2844463004/diff/180001/components/webdata/common/web_database_table.h#newcode52 > ...
3 years, 7 months ago (2017-04-27 08:32:36 UTC) #68
please use gerrit instead
Theresa, ptal chrome/android/java/src/org/chromium/chrome/browser/preferences/.
3 years, 7 months ago (2017-05-01 13:52:30 UTC) #70
Theresa
lgtm
3 years, 7 months ago (2017-05-01 15:09:33 UTC) #71
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844463004/200001
3 years, 7 months ago (2017-05-01 15:17:01 UTC) #74
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/373788)
3 years, 7 months ago (2017-05-01 16:38:08 UTC) #76
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844463004/200001
3 years, 7 months ago (2017-05-01 16:58:48 UTC) #78
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:49:37 UTC) #81
Message was sent while issue was closed.
Committed patchset #7 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/4e981bd3206d558e19b9dd04ef9c...

Powered by Google App Engine
This is Rietveld 408576698