Rename card 'type' into 'issuer network.'

Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypes        | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665
Review-Url: https://codereview.chromium.org/2844463004
Cr-Commit-Position: refs/heads/master@{#468350}
Committed: https://chromium.googlesource.com/chromium/src/+/4e981bd3206d558e19b9dd04ef9c83bd2ccb6b0f

[please use gerrit instead, 2017-04-25 19:26:25]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 19:29:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:34:32]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[please use gerrit instead, 2017-04-25 19:58:01]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-04-25 19:58:26]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-25 19:58:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-25 19:59:02]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.

In addition, this patch has been run through `git cl lint` to improve
the code quality of the affected files.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

This patch has been run through `git cl lint` to improve the code
quality of the affected files.

BUG=602665
==========

[commit-bot: I haz the power, 2017-04-25 20:10:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:10:34]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[please use gerrit instead, 2017-04-25 20:15:09]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

This patch has been run through `git cl lint` to improve the code
quality of the affected files.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
-------------------------------------------------------
| BEFORE                  | AFTER                     |
-------------------------------------------------------
| AcceptedCardTypoes      | AcceptedIssuerNetworks    |
| basic_card_payment_type | basic_card_issuer_network |
| BasicCardPaymentType    | BasicCardIssuerNetwork    |
| "card type"             | "card issuer network"     |
| Card::TypeForDisplay()  | Card::NetworkForDisplay() |
| CardTypeInfo            | CardIssuerNetwork         |
| CardTypes               | CardIssuerNetworks        |
| CreditCard::type()      | CreditCard::network()     |
| GetCreditCardType       | GetCardNetwork            |
| SetTypeForMaskedCard    | SetNetworkForMaskedCard   |
| TypeAndLastFourDigits   | NetworkAndLastFourDigits  |
| card_type               | issuer_network            |
| GetCardTypeForBasicCardPaymentType | GetIssuerNetworkForBasicCardIssuerNetwork
|
-------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` to improve the code
  quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

[please use gerrit instead, 2017-04-25 20:19:07]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:19:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-25 20:33:24]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
-------------------------------------------------------
| BEFORE                  | AFTER                     |
-------------------------------------------------------
| AcceptedCardTypoes      | AcceptedIssuerNetworks    |
| basic_card_payment_type | basic_card_issuer_network |
| BasicCardPaymentType    | BasicCardIssuerNetwork    |
| "card type"             | "card issuer network"     |
| Card::TypeForDisplay()  | Card::NetworkForDisplay() |
| CardTypeInfo            | CardIssuerNetwork         |
| CardTypes               | CardIssuerNetworks        |
| CreditCard::type()      | CreditCard::network()     |
| GetCreditCardType       | GetCardNetwork            |
| SetTypeForMaskedCard    | SetNetworkForMaskedCard   |
| TypeAndLastFourDigits   | NetworkAndLastFourDigits  |
| card_type               | issuer_network            |
| GetCardTypeForBasicCardPaymentType | GetIssuerNetworkForBasicCardIssuerNetwork
|
-------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` to improve the code
  quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
-------------------------------------------------------
| BEFORE                  | AFTER                     |
-------------------------------------------------------
| AcceptedCardTypoes      | AcceptedIssuerNetworks    |
| basic_card_payment_type | basic_card_issuer_network |
| BasicCardPaymentType    | BasicCardIssuerNetwork    |
| "card type"             | "card issuer network"     |
| CardTypeInfo            | CardIssuerNetwork         |
| card_type               | issuer_network            |
| CardTypes               | CardIssuerNetworks        |
| CreditCardType          | CardNetwork               |
| CreditCard::type        | CreditCard::network       |
| TypeAndLastFourDigits   | NetworkAndLastFourDigits  |
| TypeForDisplay          | NetworkForDisplay         |
| TypeForFill             | NetworkForFill            |
| TypeForMaskedCard       | NetworkForMaskedCard      |
| CardTypeForBasicCardPaymentType |                   |
|            | IssuerNetworkForBasicCardIssuerNetwork |
-------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

[commit-bot: I haz the power, 2017-04-25 20:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:36:46]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[please use gerrit instead, 2017-04-25 20:36:55]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
-------------------------------------------------------
| BEFORE                  | AFTER                     |
-------------------------------------------------------
| AcceptedCardTypoes      | AcceptedIssuerNetworks    |
| basic_card_payment_type | basic_card_issuer_network |
| BasicCardPaymentType    | BasicCardIssuerNetwork    |
| "card type"             | "card issuer network"     |
| CardTypeInfo            | CardIssuerNetwork         |
| card_type               | issuer_network            |
| CardTypes               | CardIssuerNetworks        |
| CreditCardType          | CardNetwork               |
| CreditCard::type        | CreditCard::network       |
| TypeAndLastFourDigits   | NetworkAndLastFourDigits  |
| TypeForDisplay          | NetworkForDisplay         |
| TypeForFill             | NetworkForFill            |
| TypeForMaskedCard       | NetworkForMaskedCard      |
| CardTypeForBasicCardPaymentType |                   |
|            | IssuerNetworkForBasicCardIssuerNetwork |
-------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| masked_credit_cards.type | masked_credit_cards.network |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

[please use gerrit instead, 2017-04-25 20:41:42]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| masked_credit_cards.type | masked_credit_cards.network |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

[please use gerrit instead, 2017-04-25 20:47:35]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:48:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-25 20:49:45]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2017-04-25 20:49:54]

Patchset #1 (id:40001) has been deleted

[please use gerrit instead, 2017-04-25 20:54:56]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2017-04-25 20:54:57]

Mathieu, PTAL overall. Sorry for the huuuuuuuge patch!

[commit-bot: I haz the power, 2017-04-25 21:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:06:33]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[please use gerrit instead, 2017-04-25 21:18:46]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-04-25 21:19:36]

Patchset #2 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-04-25 21:19:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-25 21:20:52]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because there were not
  used anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because they were not used
  anywhere.

BUG=602665
==========

[please use gerrit instead, 2017-04-25 21:21:46]

rouslan@chromium.org changed reviewers:
+ pkasting@chromium.org

[please use gerrit instead, 2017-04-25 21:21:47]

Peter, ptal components/webdata/ and autofill_table*.

[please use gerrit instead, 2017-04-25 21:23:38]

rouslan@chromium.org changed reviewers:
+ maxbogue@chromium.org

[please use gerrit instead, 2017-04-25 21:23:39]

Max, ptal single_client_wallet_sync_test.cc.

[please use gerrit instead, 2017-04-25 21:25:54]

rouslan@chromium.org changed reviewers:
+ mahmadi@chromium.org, miguelg@chromium.org

[please use gerrit instead, 2017-04-25 21:25:55]

Miguel, ptal chrome/android/java/src/org/chromium/chrome/browser/preferences/.

Moe, ptal ios/.

[please use gerrit instead, 2017-04-25 21:27:16]

rouslan@chromium.org changed reviewers:
+ lpromero@chromium.org

[please use gerrit instead, 2017-04-25 21:27:17]

Louis, ptal ios/chrome/browser/ui/settings/.

[please use gerrit instead, 2017-04-25 21:29:08]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants.* have been removed because they were not used
  anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665
==========

[please use gerrit instead, 2017-04-25 21:32:17]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[maxbogue, 2017-04-25 21:32:27]

single_client_wallet_sync_test.cc lgtm

[commit-bot: I haz the power, 2017-04-25 21:33:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-25 22:01:07]

ios/.../settings lgtm

[commit-bot: I haz the power, 2017-04-25 22:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:03:42]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[please use gerrit instead, 2017-04-25 22:20:32]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 22:21:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:04:29]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Mathieu, 2017-04-26 00:23:51]

lgtm

[Peter Kasting, 2017-04-26 01:27:28]

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:53: using
::base::TimeDelta;
Nit: Any particular reason to move these?

(I'd love to see us just nuke these if it doesn't blow up the code below too
badly, but this is already a huge CL.)

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:486:
*update_compatible_version = false;
Wait, shouldn't this be true?

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:2248: "ADD COLUMN
language_code VARCHAR");
Nit: This all fits on one line now (two places)

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:2596: if
(db_->DoesTableExist("masked_credit_cards_temp") ||
It seems like if this table exists, it will block migration continuing forever. 
That sounds bad.  When would we expect this to exist?  Why would it not be wrong
to just blow it away?

It looks like the version 71 migration has this problem too.

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:2622: return
transaction.Commit();
Nit: Up to you, but you could also write this sorta like:

  return db_.Execute(...) &&
         db_.Execute(...) &&
         ...
         transaction.Commit();

[please use gerrit instead, 2017-04-26 16:30:32]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 16:30:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-26 16:34:15]

Peter, can you explain what the compatible version number does? It sounds like
it might be used only to thwart malware that alters the sqlite database. I don't
quite follow how it works, exactly.

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:53: using
::base::TimeDelta;
On 2017/04/26 01:27:28, Peter Kasting wrote:
> Nit: Any particular reason to move these?

There's a wealth of explanations in go/totw/119. The gist is: "Declare namespace
aliases and using-declarations inside your own namespace."

> (I'd love to see us just nuke these if it doesn't blow up the code below too
> badly, but this is already a huge CL.)

Nuking works for me, because the benefit of not typing "base::" is too small.
This patch is already ~1k lines, so adding a couple extra lines does not affect
it much.

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:486:
*update_compatible_version = false;
On 2017/04/26 01:27:28, Peter Kasting wrote:
> Wait, shouldn't this be true?

Is there any documentation to read up on why this should be true or false?
There're 5 "true" and 9 "false" the switch statement. I chose the more commonly
used.

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:2248: "ADD COLUMN
language_code VARCHAR");
On 2017/04/26 01:27:28, Peter Kasting wrote:
> Nit: This all fits on one line now (two places)

Done.

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:2596: if
(db_->DoesTableExist("masked_credit_cards_temp") ||
On 2017/04/26 01:27:28, Peter Kasting wrote:
> It seems like if this table exists, it will block migration continuing
forever. 
> That sounds bad.  When would we expect this to exist?  Why would it not be
wrong
> to just blow it away?
> 
> It looks like the version 71 migration has this problem too.

Good point. Fixed in both places.

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:2622: return
transaction.Commit();
On 2017/04/26 01:27:28, Peter Kasting wrote:
> Nit: Up to you, but you could also write this sorta like:
> 
>   return db_.Execute(...) &&
>          db_.Execute(...) &&
>          ...
>          transaction.Commit();
>          

Done.

[Peter Kasting, 2017-04-26 17:47:56]

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/2844463004/diff/120001/components/autofill/co...
components/autofill/core/browser/webdata/autofill_table.cc:486:
*update_compatible_version = false;
On 2017/04/26 16:34:15, ಠ_ಠ wrote:
> On 2017/04/26 01:27:28, Peter Kasting wrote:
> > Wait, shouldn't this be true?
> 
> Is there any documentation to read up on why this should be true or false?
> There're 5 "true" and 9 "false" the switch statement. I chose the more
commonly
> used.

You need to set this to true iff you need to bump the compatible version number
-- that is, if you're changing the "compatible version" constant.

The "compatible version" is for forward compatibility -- it basically says "the
current database version is safe to read and use by code that only understands
version X".  So if Chrome 50 is built to work with version 70, and Chrome 51 is
built to work with version 71, but marks the compatible version as 70, then if
you run a profile from Chrome 51 on Chrome 50, it will happily use it.  If you
mark the compatible version here as 71, then Chrome 50 will complain that it
can't open the profile, since it's from a newer version.

Basically, it's safe to leave the compatible version alone if you're adding an
optional column to the DB, but it needs to be bumped if you're removing columns,
adding mandatory columns, or renaming things.

In this case, you're making a change that will break previous versions if they
try to read your DB, so you do need to bump the compatible version.

[commit-bot: I haz the power, 2017-04-26 18:03:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:04:00]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-04-26 18:27:57]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:28:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-26 18:33:21]

Peter, ptal patch 6.

I've expanded the comment for the meaning of the |update_compatible_version|
variable, which should improve the chances of the next non-native English
speaker understanding it on the first try. For the record, I was reading it as
"This update is compatible with the previous version," whereas you meant it as
"Please bump the compatible version field because this update is NOT compatible
with the previous version." These two are opposites. ;-)

[Peter Kasting, 2017-04-26 18:35:53]

LGTM!  Thanks for the comment update, it helps.

https://codereview.chromium.org/2844463004/diff/180001/components/webdata/com...
File components/webdata/common/web_database_table.h (right):

https://codereview.chromium.org/2844463004/diff/180001/components/webdata/com...
components/webdata/common/web_database_table.h:52: // break previous versions
when they try to read the updated database.
Nit: read -> use

(E.g. they might be able to read it OK, but break the world if they write it and
fail to stick a value in a new required field.)

[please use gerrit instead, 2017-04-26 18:37:16]

https://codereview.chromium.org/2844463004/diff/180001/components/webdata/com...
File components/webdata/common/web_database_table.h (right):

https://codereview.chromium.org/2844463004/diff/180001/components/webdata/com...
components/webdata/common/web_database_table.h:52: // break previous versions
when they try to read the updated database.
On 2017/04/26 18:35:53, Peter Kasting wrote:
> Nit: read -> use
> 
> (E.g. they might be able to read it OK, but break the world if they write it
and
> fail to stick a value in a new required field.)

Done.

[please use gerrit instead, 2017-04-26 18:37:42]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:38:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-26 18:40:10]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypoes       | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypes        | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665
==========

[commit-bot: I haz the power, 2017-04-26 19:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 19:53:18]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-04-27 08:32:36]

On 2017/04/26 18:37:16, ಠ_ಠ wrote:
>
https://codereview.chromium.org/2844463004/diff/180001/components/webdata/com...
> File components/webdata/common/web_database_table.h (right):
> 
>
https://codereview.chromium.org/2844463004/diff/180001/components/webdata/com...
> components/webdata/common/web_database_table.h:52: // break previous versions
> when they try to read the updated database.
> On 2017/04/26 18:35:53, Peter Kasting wrote:
> > Nit: read -> use
> > 
> > (E.g. they might be able to read it OK, but break the world if they write it
> and
> > fail to stick a value in a new required field.)
> 
> Done.

ios/.../payments lgtm

[please use gerrit instead, 2017-05-01 13:52:28]

rouslan@chromium.org changed reviewers:
+ twellington@chromium.org
- miguelg@chromium.org

[please use gerrit instead, 2017-05-01 13:52:30]

Theresa, ptal chrome/android/java/src/org/chromium/chrome/browser/preferences/.

[Theresa, 2017-05-01 15:09:33]

lgtm

[please use gerrit instead, 2017-05-01 15:16:47]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-05-01 15:16:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org, lpromero@chromium.org, mathp@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2844463004/#ps200001
(title: "read -> use")

[commit-bot: I haz the power, 2017-05-01 15:17:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 16:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 16:38:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-05-01 16:58:18]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-05-01 16:58:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 17:49:20]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1493657898922210,
"parent_rev": "b85de8ac470aef12f8d666b881cd9888a8b2e645", "commit_rev":
"4e981bd3206d558e19b9dd04ef9c83bd2ccb6b0f"}

[commit-bot: I haz the power, 2017-05-01 17:49:35]

Description was changed from

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypes        | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665
==========

to

==========
Rename card 'type' into 'issuer network.'

Autofill and payments code is using the word 'type' to mean 'issuer
network,' e.g., Visa, MasterCard, AmEx. In order to differentiate
between credit/debit/prepaid card types in an upcoming patch, the
current instances of the word 'type' need to be renamed to 'issuer
network.' The changes are in:

1) Autofill table.
2) Method names.
3) Variable names.
4) Comments.

The catalog of renames:
----------------------------------------------------------
| BEFORE                   | AFTER                       |
----------------------------------------------------------
| AcceptedCardTypes        | AcceptedIssuerNetworks      |
| basic_card_payment_type  | basic_card_issuer_network   |
| BasicCardPaymentType     | BasicCardIssuerNetwork      |
| "card type"              | "card issuer network"       |
| CardTypeInfo             | CardIssuerNetwork           |
| card_type                | issuer_network              |
| CardTypes                | CardIssuerNetworks          |
| CreditCardType           | CardNetwork                 |
| CreditCard::type         | CreditCard::network         |
| masked_credit_cards.type | masked_credit_cards.network |
| TypeAndLastFourDigits    | NetworkAndLastFourDigits    |
| TypeForDisplay           | NetworkForDisplay           |
| TypeForFill              | NetworkForFill              |
| TypeForMaskedCard        | NetworkForMaskedCard        |
| CardTypeForBasicCardPaymentType |                      |
|               | IssuerNetworkForBasicCardIssuerNetwork |
----------------------------------------------------------

Bonus:
* This patch has been run through `git cl lint` and `git cl format` to
  improve the code quality of the affected files.
* autofill_sync_constants have been removed because they were not used
  anywhere.

BUG=602665

Review-Url: https://codereview.chromium.org/2844463004
Cr-Commit-Position: refs/heads/master@{#468350}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e981bd3206d558e19b9dd04ef9c...
==========

[commit-bot: I haz the power, 2017-05-01 17:49:37]

Committed patchset #7 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/4e981bd3206d558e19b9dd04ef9c...