Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)
Patch Set: read -> use Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
diff --git a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
index 00c26f4c732115e2facd65260a04103c02abc50e..2fd1c6cf551636f84a20ab15e0cbb20a1caed444 100644
--- a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
+++ b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
@@ -225,7 +225,7 @@ base::string16 CardUnmaskPromptControllerImpl::GetWindowTitle() const {
ShouldRequestExpirationDate()
? IDS_AUTOFILL_CARD_UNMASK_PROMPT_EXPIRED_TITLE
: IDS_AUTOFILL_CARD_UNMASK_PROMPT_TITLE,
- card_.TypeAndLastFourDigits());
+ card_.NetworkAndLastFourDigits());
#endif
}
@@ -240,7 +240,7 @@ base::string16 CardUnmaskPromptControllerImpl::GetInstructionsMessage() const {
}
// The iOS UI shows the card details in the instructions text since they
// don't fit in the title.
- return l10n_util::GetStringFUTF16(ids, card_.TypeAndLastFourDigits());
+ return l10n_util::GetStringFUTF16(ids, card_.NetworkAndLastFourDigits());
#else
return l10n_util::GetStringUTF16(
IDS_AUTOFILL_CARD_UNMASK_PROMPT_INSTRUCTIONS);
@@ -252,8 +252,8 @@ base::string16 CardUnmaskPromptControllerImpl::GetOkButtonLabel() const {
}
int CardUnmaskPromptControllerImpl::GetCvcImageRid() const {
- return card_.type() == kAmericanExpressCard ? IDR_CREDIT_CARD_CVC_HINT_AMEX
- : IDR_CREDIT_CARD_CVC_HINT;
+ return card_.network() == kAmericanExpressCard ? IDR_CREDIT_CARD_CVC_HINT_AMEX
+ : IDR_CREDIT_CARD_CVC_HINT;
}
bool CardUnmaskPromptControllerImpl::ShouldRequestExpirationDate() const {
@@ -281,7 +281,7 @@ bool CardUnmaskPromptControllerImpl::InputCvcIsValid(
const base::string16& input_text) const {
base::string16 trimmed_text;
base::TrimWhitespace(input_text, base::TRIM_ALL, &trimmed_text);
- return IsValidCreditCardSecurityCode(trimmed_text, card_.type());
+ return IsValidCreditCardSecurityCode(trimmed_text, card_.network());
}
bool CardUnmaskPromptControllerImpl::InputExpirationIsValid(
@@ -310,7 +310,7 @@ bool CardUnmaskPromptControllerImpl::InputExpirationIsValid(
}
int CardUnmaskPromptControllerImpl::GetExpectedCvcLength() const {
- return GetCvcLengthForCardType(card_.type());
+ return GetCvcLengthForCardType(card_.network());
}
base::TimeDelta CardUnmaskPromptControllerImpl::GetSuccessMessageDuration()
« no previous file with comments | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | components/autofill/core/browser/validation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698