Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)
Patch Set: read -> use Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autofill/android/personal_data_manager_android.h" 5 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 MaybeSetRawInfo(profile, autofill::EMAIL_ADDRESS, 131 MaybeSetRawInfo(profile, autofill::EMAIL_ADDRESS,
132 Java_AutofillProfile_getEmailAddress(env, jprofile)); 132 Java_AutofillProfile_getEmailAddress(env, jprofile));
133 profile->set_language_code(ConvertJavaStringToUTF8( 133 profile->set_language_code(ConvertJavaStringToUTF8(
134 Java_AutofillProfile_getLanguageCode(env, jprofile))); 134 Java_AutofillProfile_getLanguageCode(env, jprofile)));
135 } 135 }
136 136
137 ScopedJavaLocalRef<jobject> CreateJavaCreditCardFromNative( 137 ScopedJavaLocalRef<jobject> CreateJavaCreditCardFromNative(
138 JNIEnv* env, 138 JNIEnv* env,
139 const CreditCard& card) { 139 const CreditCard& card) {
140 const data_util::PaymentRequestData& payment_request_data = 140 const data_util::PaymentRequestData& payment_request_data =
141 data_util::GetPaymentRequestData(card.type()); 141 data_util::GetPaymentRequestData(card.network());
142 return Java_CreditCard_create( 142 return Java_CreditCard_create(
143 env, ConvertUTF8ToJavaString(env, card.guid()), 143 env, ConvertUTF8ToJavaString(env, card.guid()),
144 ConvertUTF8ToJavaString(env, card.origin()), 144 ConvertUTF8ToJavaString(env, card.origin()),
145 card.record_type() == CreditCard::LOCAL_CARD, 145 card.record_type() == CreditCard::LOCAL_CARD,
146 card.record_type() == CreditCard::FULL_SERVER_CARD, 146 card.record_type() == CreditCard::FULL_SERVER_CARD,
147 ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_NAME_FULL)), 147 ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_NAME_FULL)),
148 ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_NUMBER)), 148 ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_NUMBER)),
149 ConvertUTF16ToJavaString(env, card.TypeAndLastFourDigits()), 149 ConvertUTF16ToJavaString(env, card.NetworkAndLastFourDigits()),
150 ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_EXP_MONTH)), 150 ConvertUTF16ToJavaString(env, card.GetRawInfo(CREDIT_CARD_EXP_MONTH)),
151 ConvertUTF16ToJavaString(env, 151 ConvertUTF16ToJavaString(env,
152 card.GetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR)), 152 card.GetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR)),
153 ConvertUTF8ToJavaString(env, 153 ConvertUTF8ToJavaString(env,
154 payment_request_data.basic_card_payment_type), 154 payment_request_data.basic_card_issuer_network),
155 ResourceMapper::MapFromChromiumId(payment_request_data.icon_resource_id), 155 ResourceMapper::MapFromChromiumId(payment_request_data.icon_resource_id),
156 ConvertUTF8ToJavaString(env, card.billing_address_id()), 156 ConvertUTF8ToJavaString(env, card.billing_address_id()),
157 ConvertUTF8ToJavaString(env, card.server_id())); 157 ConvertUTF8ToJavaString(env, card.server_id()));
158 } 158 }
159 159
160 void PopulateNativeCreditCardFromJava( 160 void PopulateNativeCreditCardFromJava(
161 const jobject& jcard, 161 const jobject& jcard,
162 JNIEnv* env, 162 JNIEnv* env,
163 CreditCard* card) { 163 CreditCard* card) {
164 card->set_origin( 164 card->set_origin(
(...skipping 22 matching lines...) Expand all
187 if (!guid.empty()) 187 if (!guid.empty())
188 card->set_guid(guid); 188 card->set_guid(guid);
189 189
190 if (Java_CreditCard_getIsLocal(env, jcard)) { 190 if (Java_CreditCard_getIsLocal(env, jcard)) {
191 card->set_record_type(CreditCard::LOCAL_CARD); 191 card->set_record_type(CreditCard::LOCAL_CARD);
192 } else { 192 } else {
193 if (Java_CreditCard_getIsCached(env, jcard)) { 193 if (Java_CreditCard_getIsCached(env, jcard)) {
194 card->set_record_type(CreditCard::FULL_SERVER_CARD); 194 card->set_record_type(CreditCard::FULL_SERVER_CARD);
195 } else { 195 } else {
196 card->set_record_type(CreditCard::MASKED_SERVER_CARD); 196 card->set_record_type(CreditCard::MASKED_SERVER_CARD);
197 card->SetTypeForMaskedCard( 197 card->SetNetworkForMaskedCard(
198 data_util::GetCardTypeForBasicCardPaymentType(ConvertJavaStringToUTF8( 198 data_util::GetIssuerNetworkForBasicCardIssuerNetwork(
199 env, Java_CreditCard_getBasicCardPaymentType(env, jcard)))); 199 ConvertJavaStringToUTF8(
200 env, Java_CreditCard_getBasicCardIssuerNetwork(env, jcard))));
200 } 201 }
201 } 202 }
202 } 203 }
203 204
204 // Self-deleting requester of full card details, including full PAN and the CVC 205 // Self-deleting requester of full card details, including full PAN and the CVC
205 // number. 206 // number.
206 class FullCardRequester : public payments::FullCardRequest::ResultDelegate, 207 class FullCardRequester : public payments::FullCardRequest::ResultDelegate,
207 public base::SupportsWeakPtr<FullCardRequester> { 208 public base::SupportsWeakPtr<FullCardRequester> {
208 public: 209 public:
209 FullCardRequester() {} 210 FullCardRequester() {}
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 void PersonalDataManagerAndroid::UpdateServerCardBillingAddress( 527 void PersonalDataManagerAndroid::UpdateServerCardBillingAddress(
527 JNIEnv* env, 528 JNIEnv* env,
528 const JavaParamRef<jobject>& unused_obj, 529 const JavaParamRef<jobject>& unused_obj,
529 const JavaParamRef<jobject>& jcard) { 530 const JavaParamRef<jobject>& jcard) {
530 CreditCard card; 531 CreditCard card;
531 PopulateNativeCreditCardFromJava(jcard, env, &card); 532 PopulateNativeCreditCardFromJava(jcard, env, &card);
532 533
533 personal_data_manager_->UpdateServerCardMetadata(card); 534 personal_data_manager_->UpdateServerCardMetadata(card);
534 } 535 }
535 536
536 ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::GetBasicCardPaymentType( 537 ScopedJavaLocalRef<jstring>
538 PersonalDataManagerAndroid::GetBasicCardIssuerNetwork(
537 JNIEnv* env, 539 JNIEnv* env,
538 const JavaParamRef<jobject>& unused_obj, 540 const JavaParamRef<jobject>& unused_obj,
539 const JavaParamRef<jstring>& jcard_number, 541 const JavaParamRef<jstring>& jcard_number,
540 const jboolean jempty_if_invalid) { 542 const jboolean jempty_if_invalid) {
541 base::string16 card_number = ConvertJavaStringToUTF16(env, jcard_number); 543 base::string16 card_number = ConvertJavaStringToUTF16(env, jcard_number);
542 544
543 if (static_cast<bool>(jempty_if_invalid) && 545 if (static_cast<bool>(jempty_if_invalid) &&
544 !IsValidCreditCardNumber(card_number)) { 546 !IsValidCreditCardNumber(card_number)) {
545 return ConvertUTF8ToJavaString(env, ""); 547 return ConvertUTF8ToJavaString(env, "");
546 } 548 }
547 return ConvertUTF8ToJavaString(env, 549 return ConvertUTF8ToJavaString(
548 data_util::GetPaymentRequestData( 550 env,
549 CreditCard::GetCreditCardType(card_number)) 551 data_util::GetPaymentRequestData(CreditCard::GetCardNetwork(card_number))
550 .basic_card_payment_type); 552 .basic_card_issuer_network);
551 } 553 }
552 554
553 void PersonalDataManagerAndroid::AddServerCreditCardForTest( 555 void PersonalDataManagerAndroid::AddServerCreditCardForTest(
554 JNIEnv* env, 556 JNIEnv* env,
555 const base::android::JavaParamRef<jobject>& unused_obj, 557 const base::android::JavaParamRef<jobject>& unused_obj,
556 const base::android::JavaParamRef<jobject>& jcard) { 558 const base::android::JavaParamRef<jobject>& jcard) {
557 std::unique_ptr<CreditCard> card(new CreditCard); 559 std::unique_ptr<CreditCard> card(new CreditCard);
558 PopulateNativeCreditCardFromJava(jcard, env, card.get()); 560 PopulateNativeCreditCardFromJava(jcard, env, card.get());
559 card->set_record_type(CreditCard::MASKED_SERVER_CARD); 561 card->set_record_type(CreditCard::MASKED_SERVER_CARD);
560 personal_data_manager_->AddServerCreditCardForTest(std::move(card)); 562 personal_data_manager_->AddServerCreditCardForTest(std::move(card));
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 base::android::ConvertJavaStringToUTF16(env, jcountry_name))); 875 base::android::ConvertJavaStringToUTF16(env, jcountry_name)));
874 } 876 }
875 877
876 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) { 878 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
877 PersonalDataManagerAndroid* personal_data_manager_android = 879 PersonalDataManagerAndroid* personal_data_manager_android =
878 new PersonalDataManagerAndroid(env, obj); 880 new PersonalDataManagerAndroid(env, obj);
879 return reinterpret_cast<intptr_t>(personal_data_manager_android); 881 return reinterpret_cast<intptr_t>(personal_data_manager_android);
880 } 882 }
881 883
882 } // namespace autofill 884 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698