Rename card 'type' into 'issuer network.'

components/webdata/common/web_database_table.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_
 #define COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "components/webdata/common/webdata_export.h"
@@ skipping 29 matching lines @@
   // In order to encourage developers to think about sync when adding or
   // or altering new tables, this method must be implemented. Please get in
   // contact with the sync team if you believe you're making a change that they
   // should be aware of (or if you could break something).
   // TODO(andybons): Implement something more robust.
   virtual bool IsSyncable() = 0;
 
   // Migrates this table to |version|. Returns false if there was
   // migration work to do and it failed, true otherwise.
   //
-  // Implementations may set |*update_compatible_version| to true if
-  // the compatible version should be changed to |version|.
+  // Implementations may set |*update_compatible_version| to true if the
+  // compatible version should be changed to |version|, i.e., if the change will
+  // break previous versions when they try to read the updated database.

[Peter Kasting, 2017/04/26 18:35:53]

Nit: read -> use

(E.g. they might be able to read it OK, but break the world if they write it and
fail to stick a value in a new required field.)

[please use gerrit instead, 2017/04/26 18:37:16]

Done.

   // Implementations should otherwise not modify this parameter.
   virtual bool MigrateToVersion(int version,
                                 bool* update_compatible_version) = 0;
 
  protected:
   // Non-owning. These are owned by WebDatabase, valid as long as that
   // class exists. Since lifetime of WebDatabaseTable objects slightly
   // exceeds that of WebDatabase, they should not be used in
   // ~WebDatabaseTable.
   sql::Connection* db_;
   sql::MetaTable* meta_table_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WebDatabaseTable);
 };
 
 #endif  // COMPONENTS_WEBDATA_COMMON_WEB_DATABASE_TABLE_H_