Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)
Patch Set: read -> use Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.cc
diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc
index bb3495af87da27e0eb29caa29e67f19513b497ef..4c00de1bc4d4ec159d73747e3bcf57f3fd82ddef 100644
--- a/components/autofill/core/browser/personal_data_manager.cc
+++ b/components/autofill/core/browser/personal_data_manager.cc
@@ -1625,7 +1625,7 @@ std::vector<Suggestion> PersonalDataManager::GetSuggestionsForCards(
Suggestion* suggestion = &suggestions.back();
suggestion->value = credit_card->GetInfo(type, app_locale_);
- suggestion->icon = base::UTF8ToUTF16(credit_card->type());
+ suggestion->icon = base::UTF8ToUTF16(credit_card->network());
suggestion->backend_id = credit_card->guid();
suggestion->match = prefix_matched_suggestion
? Suggestion::PREFIX_MATCH
@@ -1635,7 +1635,7 @@ std::vector<Suggestion> PersonalDataManager::GetSuggestionsForCards(
// Otherwise the label is the card number, or if that is empty the
// cardholder name. The label should never repeat the value.
if (type.GetStorableType() == CREDIT_CARD_NUMBER) {
- suggestion->value = credit_card->TypeAndLastFourDigits();
+ suggestion->value = credit_card->NetworkAndLastFourDigits();
if (IsAutofillCreditCardLastUsedDateDisplayExperimentEnabled()) {
suggestion->label =
credit_card->GetLastUsedDateForDisplay(app_locale_);
@@ -1655,7 +1655,7 @@ std::vector<Suggestion> PersonalDataManager::GetSuggestionsForCards(
// Since Android places the label on its own row, there's more
// horizontal
// space to work with. Show "Amex - 1234" rather than desktop's "*1234".
- suggestion->label = credit_card->TypeAndLastFourDigits();
+ suggestion->label = credit_card->NetworkAndLastFourDigits();
#else
suggestion->label = base::ASCIIToUTF16("*");
suggestion->label.append(credit_card->LastFourDigits());

Powered by Google App Engine
This is Rietveld 408576698