Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

Issue 2844463004: Rename card 'type' into 'issuer network.' (Closed)
Patch Set: read -> use Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.autofill; 5 package org.chromium.chrome.browser.autofill;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 8
9 import org.chromium.base.ThreadUtils; 9 import org.chromium.base.ThreadUtils;
10 import org.chromium.base.VisibleForTesting; 10 import org.chromium.base.VisibleForTesting;
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 // marshaled and compared as strings. To save conversions, we use string s everywhere. 339 // marshaled and compared as strings. To save conversions, we use string s everywhere.
340 private String mGUID; 340 private String mGUID;
341 private String mOrigin; 341 private String mOrigin;
342 private boolean mIsLocal; 342 private boolean mIsLocal;
343 private boolean mIsCached; 343 private boolean mIsCached;
344 private String mName; 344 private String mName;
345 private String mNumber; 345 private String mNumber;
346 private String mObfuscatedNumber; 346 private String mObfuscatedNumber;
347 private String mMonth; 347 private String mMonth;
348 private String mYear; 348 private String mYear;
349 private String mBasicCardPaymentType; 349 private String mBasicCardIssuerNetwork;
350 private int mIssuerIconDrawableId; 350 private int mIssuerIconDrawableId;
351 private String mBillingAddressId; 351 private String mBillingAddressId;
352 private String mServerId; 352 private String mServerId;
353 353
354 @CalledByNative("CreditCard") 354 @CalledByNative("CreditCard")
355 public static CreditCard create(String guid, String origin, boolean isLo cal, 355 public static CreditCard create(String guid, String origin, boolean isLo cal,
356 boolean isCached, String name, String number, String obfuscatedN umber, String month, 356 boolean isCached, String name, String number, String obfuscatedN umber, String month,
357 String year, String basicCardPaymentType, int enumeratedIconId, 357 String year, String basicCardIssuerNetwork, int enumeratedIconId ,
358 String billingAddressId, String serverId) { 358 String billingAddressId, String serverId) {
359 return new CreditCard(guid, origin, isLocal, isCached, name, number, obfuscatedNumber, 359 return new CreditCard(guid, origin, isLocal, isCached, name, number, obfuscatedNumber,
360 month, year, basicCardPaymentType, ResourceId.mapToDrawableI d(enumeratedIconId), 360 month, year, basicCardIssuerNetwork,
361 billingAddressId, serverId); 361 ResourceId.mapToDrawableId(enumeratedIconId), billingAddress Id, serverId);
362 } 362 }
363 363
364 public CreditCard(String guid, String origin, boolean isLocal, boolean i sCached, 364 public CreditCard(String guid, String origin, boolean isLocal, boolean i sCached,
365 String name, String number, String obfuscatedNumber, String mont h, String year, 365 String name, String number, String obfuscatedNumber, String mont h, String year,
366 String basicCardPaymentType, int issuerIconDrawableId, String bi llingAddressId, 366 String basicCardIssuerNetwork, int issuerIconDrawableId, String billingAddressId,
367 String serverId) { 367 String serverId) {
368 mGUID = guid; 368 mGUID = guid;
369 mOrigin = origin; 369 mOrigin = origin;
370 mIsLocal = isLocal; 370 mIsLocal = isLocal;
371 mIsCached = isCached; 371 mIsCached = isCached;
372 mName = name; 372 mName = name;
373 mNumber = number; 373 mNumber = number;
374 mObfuscatedNumber = obfuscatedNumber; 374 mObfuscatedNumber = obfuscatedNumber;
375 mMonth = month; 375 mMonth = month;
376 mYear = year; 376 mYear = year;
377 mBasicCardPaymentType = basicCardPaymentType; 377 mBasicCardIssuerNetwork = basicCardIssuerNetwork;
378 mIssuerIconDrawableId = issuerIconDrawableId; 378 mIssuerIconDrawableId = issuerIconDrawableId;
379 mBillingAddressId = billingAddressId; 379 mBillingAddressId = billingAddressId;
380 mServerId = serverId; 380 mServerId = serverId;
381 } 381 }
382 382
383 public CreditCard() { 383 public CreditCard() {
384 this("" /* guid */, AutofillAndPaymentsPreferences.SETTINGS_ORIGIN / *origin */, 384 this("" /* guid */, AutofillAndPaymentsPreferences.SETTINGS_ORIGIN / *origin */,
385 true /* isLocal */, false /* isCached */, "" /* name */, "" /* number */, 385 true /* isLocal */, false /* isCached */, "" /* name */, "" /* number */,
386 "" /* obfuscatedNumber */, "" /* month */, "" /* year */, 386 "" /* obfuscatedNumber */, "" /* month */, "" /* year */,
387 "" /* basicCardPaymentType */, 0 /* issuerIconDrawableId */, 387 "" /* basicCardIssuerNetwork */, 0 /* issuerIconDrawableId * /,
388 "" /* billingAddressId */, "" /* serverId */); 388 "" /* billingAddressId */, "" /* serverId */);
389 } 389 }
390 390
391 /** TODO(estade): remove this constructor. */ 391 /** TODO(estade): remove this constructor. */
392 @VisibleForTesting 392 @VisibleForTesting
393 public CreditCard(String guid, String origin, String name, String number , 393 public CreditCard(String guid, String origin, String name, String number ,
394 String obfuscatedNumber, String month, String year) { 394 String obfuscatedNumber, String month, String year) {
395 this(guid, origin, true /* isLocal */, false /* isCached */, name, n umber, 395 this(guid, origin, true /* isLocal */, false /* isCached */, name, n umber,
396 obfuscatedNumber, month, year, "" /* basicCardPaymentType */ , 396 obfuscatedNumber, month, year, "" /* basicCardIssuerNetwork */,
397 0 /* issuerIconDrawableId */, "" /* billingAddressId */, "" /* serverId */); 397 0 /* issuerIconDrawableId */, "" /* billingAddressId */, "" /* serverId */);
398 } 398 }
399 399
400 @CalledByNative("CreditCard") 400 @CalledByNative("CreditCard")
401 public String getGUID() { 401 public String getGUID() {
402 return mGUID; 402 return mGUID;
403 } 403 }
404 404
405 @CalledByNative("CreditCard") 405 @CalledByNative("CreditCard")
406 public String getOrigin() { 406 public String getOrigin() {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 public boolean getIsLocal() { 441 public boolean getIsLocal() {
442 return mIsLocal; 442 return mIsLocal;
443 } 443 }
444 444
445 @CalledByNative("CreditCard") 445 @CalledByNative("CreditCard")
446 public boolean getIsCached() { 446 public boolean getIsCached() {
447 return mIsCached; 447 return mIsCached;
448 } 448 }
449 449
450 @CalledByNative("CreditCard") 450 @CalledByNative("CreditCard")
451 public String getBasicCardPaymentType() { 451 public String getBasicCardIssuerNetwork() {
452 return mBasicCardPaymentType; 452 return mBasicCardIssuerNetwork;
453 } 453 }
454 454
455 public int getIssuerIconDrawableId() { 455 public int getIssuerIconDrawableId() {
456 return mIssuerIconDrawableId; 456 return mIssuerIconDrawableId;
457 } 457 }
458 458
459 @CalledByNative("CreditCard") 459 @CalledByNative("CreditCard")
460 public String getBillingAddressId() { 460 public String getBillingAddressId() {
461 return mBillingAddressId; 461 return mBillingAddressId;
462 } 462 }
(...skipping 27 matching lines...) Expand all
490 490
491 @VisibleForTesting 491 @VisibleForTesting
492 public void setMonth(String month) { 492 public void setMonth(String month) {
493 mMonth = month; 493 mMonth = month;
494 } 494 }
495 495
496 public void setYear(String year) { 496 public void setYear(String year) {
497 mYear = year; 497 mYear = year;
498 } 498 }
499 499
500 public void setBasicCardPaymentType(String type) { 500 public void setBasicCardIssuerNetwork(String network) {
501 mBasicCardPaymentType = type; 501 mBasicCardIssuerNetwork = network;
502 } 502 }
503 503
504 public void setIssuerIconDrawableId(int id) { 504 public void setIssuerIconDrawableId(int id) {
505 mIssuerIconDrawableId = id; 505 mIssuerIconDrawableId = id;
506 } 506 }
507 507
508 public void setBillingAddressId(String id) { 508 public void setBillingAddressId(String id) {
509 mBillingAddressId = id; 509 mBillingAddressId = id;
510 } 510 }
511 } 511 }
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 ThreadUtils.assertOnUiThread(); 685 ThreadUtils.assertOnUiThread();
686 assert card.getIsLocal(); 686 assert card.getIsLocal();
687 return nativeSetCreditCard(mPersonalDataManagerAndroid, card); 687 return nativeSetCreditCard(mPersonalDataManagerAndroid, card);
688 } 688 }
689 689
690 public void updateServerCardBillingAddress(CreditCard card) { 690 public void updateServerCardBillingAddress(CreditCard card) {
691 ThreadUtils.assertOnUiThread(); 691 ThreadUtils.assertOnUiThread();
692 nativeUpdateServerCardBillingAddress(mPersonalDataManagerAndroid, card); 692 nativeUpdateServerCardBillingAddress(mPersonalDataManagerAndroid, card);
693 } 693 }
694 694
695 public String getBasicCardPaymentType(String cardNumber, boolean emptyIfInva lid) { 695 public String getBasicCardIssuerNetwork(String cardNumber, boolean emptyIfIn valid) {
696 ThreadUtils.assertOnUiThread(); 696 ThreadUtils.assertOnUiThread();
697 return nativeGetBasicCardPaymentType( 697 return nativeGetBasicCardIssuerNetwork(
698 mPersonalDataManagerAndroid, cardNumber, emptyIfInvalid); 698 mPersonalDataManagerAndroid, cardNumber, emptyIfInvalid);
699 } 699 }
700 700
701 @VisibleForTesting 701 @VisibleForTesting
702 public void addServerCreditCardForTest(CreditCard card) { 702 public void addServerCreditCardForTest(CreditCard card) {
703 ThreadUtils.assertOnUiThread(); 703 ThreadUtils.assertOnUiThread();
704 assert !card.getIsLocal(); 704 assert !card.getIsLocal();
705 nativeAddServerCreditCardForTest(mPersonalDataManagerAndroid, card); 705 nativeAddServerCreditCardForTest(mPersonalDataManagerAndroid, card);
706 } 706 }
707 707
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 private native String[] nativeGetCreditCardGUIDsToSuggest( 914 private native String[] nativeGetCreditCardGUIDsToSuggest(
915 long nativePersonalDataManagerAndroid); 915 long nativePersonalDataManagerAndroid);
916 private native CreditCard nativeGetCreditCardByGUID(long nativePersonalDataM anagerAndroid, 916 private native CreditCard nativeGetCreditCardByGUID(long nativePersonalDataM anagerAndroid,
917 String guid); 917 String guid);
918 private native CreditCard nativeGetCreditCardForNumber(long nativePersonalDa taManagerAndroid, 918 private native CreditCard nativeGetCreditCardForNumber(long nativePersonalDa taManagerAndroid,
919 String cardNumber); 919 String cardNumber);
920 private native String nativeSetCreditCard(long nativePersonalDataManagerAndr oid, 920 private native String nativeSetCreditCard(long nativePersonalDataManagerAndr oid,
921 CreditCard card); 921 CreditCard card);
922 private native void nativeUpdateServerCardBillingAddress(long nativePersonal DataManagerAndroid, 922 private native void nativeUpdateServerCardBillingAddress(long nativePersonal DataManagerAndroid,
923 CreditCard card); 923 CreditCard card);
924 private native String nativeGetBasicCardPaymentType( 924 private native String nativeGetBasicCardIssuerNetwork(
925 long nativePersonalDataManagerAndroid, String cardNumber, boolean em ptyIfInvalid); 925 long nativePersonalDataManagerAndroid, String cardNumber, boolean em ptyIfInvalid);
926 private native void nativeAddServerCreditCardForTest(long nativePersonalData ManagerAndroid, 926 private native void nativeAddServerCreditCardForTest(long nativePersonalData ManagerAndroid,
927 CreditCard card); 927 CreditCard card);
928 private native void nativeRemoveByGUID(long nativePersonalDataManagerAndroid , String guid); 928 private native void nativeRemoveByGUID(long nativePersonalDataManagerAndroid , String guid);
929 private native void nativeRecordAndLogProfileUse(long nativePersonalDataMana gerAndroid, 929 private native void nativeRecordAndLogProfileUse(long nativePersonalDataMana gerAndroid,
930 String guid); 930 String guid);
931 private native void nativeSetProfileUseStatsForTesting( 931 private native void nativeSetProfileUseStatsForTesting(
932 long nativePersonalDataManagerAndroid, String guid, int count, long date); 932 long nativePersonalDataManagerAndroid, String guid, int count, long date);
933 private native int nativeGetProfileUseCountForTesting(long nativePersonalDat aManagerAndroid, 933 private native int nativeGetProfileUseCountForTesting(long nativePersonalDat aManagerAndroid,
934 String guid); 934 String guid);
(...skipping 19 matching lines...) Expand all
954 NormalizedAddressRequestDelegate delegate); 954 NormalizedAddressRequestDelegate delegate);
955 private static native boolean nativeHasProfiles(long nativePersonalDataManag erAndroid); 955 private static native boolean nativeHasProfiles(long nativePersonalDataManag erAndroid);
956 private static native boolean nativeHasCreditCards(long nativePersonalDataMa nagerAndroid); 956 private static native boolean nativeHasCreditCards(long nativePersonalDataMa nagerAndroid);
957 private static native boolean nativeIsAutofillEnabled(); 957 private static native boolean nativeIsAutofillEnabled();
958 private static native void nativeSetAutofillEnabled(boolean enable); 958 private static native void nativeSetAutofillEnabled(boolean enable);
959 private static native boolean nativeIsAutofillManaged(); 959 private static native boolean nativeIsAutofillManaged();
960 private static native boolean nativeIsPaymentsIntegrationEnabled(); 960 private static native boolean nativeIsPaymentsIntegrationEnabled();
961 private static native void nativeSetPaymentsIntegrationEnabled(boolean enabl e); 961 private static native void nativeSetPaymentsIntegrationEnabled(boolean enabl e);
962 private static native String nativeToCountryCode(String countryName); 962 private static native String nativeToCountryCode(String countryName);
963 } 963 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698