Pass u2f message callback vector as a const reference

Pass u2f message callback vector as a const reference

Switch to using a const reference in the U2fDevice
MessageCallback. This will prevent an extra copy
of the data being made.

BUG=686302
Review-Url: https://codereview.chromium.org/2839043002
Cr-Commit-Position: refs/heads/master@{#467187}
Committed: https://chromium.googlesource.com/chromium/src/+/01360ba4c079833a099cd9ec684da2b9748291b8

[Casey Piper, 2017-04-25 23:27:25]

piperc@chromium.org changed reviewers:
+ kpaulhamus@chromium.org, reillyg@chromium.org

[Casey Piper, 2017-04-25 23:27:25]

piperc@chromium.org changed required reviewers:
+ reillyg@chromium.org

[Casey Piper, 2017-04-25 23:27:25]

Hey Reilly,

This patch is to follow up on:
https://codereview.chromium.org/2821263005/diff/160001/device/u2f/u2f_sign.h#...

Can you take a look?
Thanks!

[Casey Piper, 2017-04-25 23:30:02]

The CQ bit was checked by piperc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:30:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 23:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 23:46:19]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-04-26 00:11:03]

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc
File device/u2f/u2f_register.cc (right):

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc#...
device/u2f/u2f_register.cc:45: cb_.Run(return_code, response_data);
U2fRequest::ResponseCallback should also be updated to prevent a copy here.

[piperc, 2017-04-26 00:19:55]

piperc@google.com changed reviewers:
+ piperc@google.com

[piperc, 2017-04-26 00:19:56]

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc
File device/u2f/u2f_register.cc (right):

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc#...
device/u2f/u2f_register.cc:45: cb_.Run(return_code, response_data);
On 2017/04/26 00:11:02, Reilly Grant wrote:
> U2fRequest::ResponseCallback should also be updated to prevent a copy here.

Will the caller need to do a move of the data before the U2fRequest goes out of
scope?

[Reilly Grant (use Gerrit), 2017-04-26 00:28:00]

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc
File device/u2f/u2f_register.cc (right):

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc#...
device/u2f/u2f_register.cc:45: cb_.Run(return_code, response_data);
On 2017/04/26 00:19:55, piperc wrote:
> On 2017/04/26 00:11:02, Reilly Grant wrote:
> > U2fRequest::ResponseCallback should also be updated to prevent a copy here.
> 
> Will the caller need to do a move of the data before the U2fRequest goes out
of
> scope? 

The function bound to |cb_| is called from inside this stack frame so
|response_data| will still be valid.

[Casey Piper, 2017-04-26 00:39:05]

piperc@chromium.org changed reviewers:
- piperc@google.com

[Casey Piper, 2017-04-26 00:39:05]

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc
File device/u2f/u2f_register.cc (right):

https://codereview.chromium.org/2839043002/diff/1/device/u2f/u2f_register.cc#...
device/u2f/u2f_register.cc:45: cb_.Run(return_code, response_data);
On 2017/04/26 00:28:00, Reilly Grant wrote:
> On 2017/04/26 00:19:55, piperc wrote:
> > On 2017/04/26 00:11:02, Reilly Grant wrote:
> > > U2fRequest::ResponseCallback should also be updated to prevent a copy
here.
> > 
> > Will the caller need to do a move of the data before the U2fRequest goes out
> of
> > scope? 
> 
> The function bound to |cb_| is called from inside this stack frame so
> |response_data| will still be valid.

Right. Makes sense.
Done.

[Reilly Grant (use Gerrit), 2017-04-26 00:40:27]

lgtm

[piperc, 2017-04-26 00:40:41]

The CQ bit was checked by piperc@google.com

[commit-bot: I haz the power, 2017-04-26 00:41:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:56:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493167241008050,
"parent_rev": "ae9712079d2b34e4a543a8f04de581a3b7bfd383", "commit_rev":
"01360ba4c079833a099cd9ec684da2b9748291b8"}

[commit-bot: I haz the power, 2017-04-26 00:57:31]

Description was changed from

==========
Pass u2f message callback vector as a const reference

Switch to using a const reference in the U2fDevice
MessageCallback. This will prevent an extra copy
of the data being made.

BUG=686302
==========

to

==========
Pass u2f message callback vector as a const reference

Switch to using a const reference in the U2fDevice
MessageCallback. This will prevent an extra copy
of the data being made.

BUG=686302

Review-Url: https://codereview.chromium.org/2839043002
Cr-Commit-Position: refs/heads/master@{#467187}
Committed:
https://chromium.googlesource.com/chromium/src/+/01360ba4c079833a099cd9ec684d...
==========

[commit-bot: I haz the power, 2017-04-26 00:57:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/01360ba4c079833a099cd9ec684d...