Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: device/u2f/u2f_sign_unittest.cc

Issue 2839043002: Pass u2f message callback vector as a const reference (Closed)
Patch Set: Change response callback to const ref Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/u2f/u2f_sign.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/u2f/u2f_sign_unittest.cc
diff --git a/device/u2f/u2f_sign_unittest.cc b/device/u2f/u2f_sign_unittest.cc
index 8c846217ae9ca9f8ff900dc42729cace87905009..95650cad6885b9400223ed4ca5f7289ee1c27e1d 100644
--- a/device/u2f/u2f_sign_unittest.cc
+++ b/device/u2f/u2f_sign_unittest.cc
@@ -37,7 +37,7 @@ class TestSignCallback {
~TestSignCallback() {}
void ReceivedCallback(U2fReturnCode status_code,
- std::vector<uint8_t> response) {
+ const std::vector<uint8_t>& response) {
response_ = std::make_pair(status_code, response);
closure_.Run();
}
« no previous file with comments | « device/u2f/u2f_sign.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698