device/u2f/u2f_register_unittest.cc - Issue 2839043002: Pass u2f message callback vector as a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/u2f/u2f_register_unittest.cc

Issue 2839043002: Pass u2f message callback vector as a const reference (Closed)

Patch Set: Change response callback to const ref Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/u2f/u2f_register_unittest.cc

diff --git a/device/u2f/u2f_register_unittest.cc b/device/u2f/u2f_register_unittest.cc

index 2d0d2d4f999161ee504e123b4359e63b7adff1a6..6b183da56e302e3a9645a0f0a54a966360a08a1b 100644

--- a/device/u2f/u2f_register_unittest.cc

+++ b/device/u2f/u2f_register_unittest.cc

@@ -38,7 +38,7 @@ class TestRegisterCallback {

~TestRegisterCallback() {}

void ReceivedCallback(U2fReturnCode status_code,

- std::vector<uint8_t> response) {

+ const std::vector<uint8_t>& response) {

response_ = std::make_pair(status_code, response);

closure_.Run();

}

« no previous file with comments | « device/u2f/u2f_register.cc ('k') | device/u2f/u2f_request.h » ('j') | no next file with comments »