device/u2f/u2f_device.h - Issue 2839043002: Pass u2f message callback vector as a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/u2f/u2f_device.h

Issue 2839043002: Pass u2f message callback vector as a const reference (Closed)

Patch Set: Change response callback to const ref Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/u2f/u2f_device.h

diff --git a/device/u2f/u2f_device.h b/device/u2f/u2f_device.h

index 9537d44bac422e5c3d795ebee7461cc6b788028b..2a5323dbc4d53849afc4d4b02170597789834f6b 100644

--- a/device/u2f/u2f_device.h

+++ b/device/u2f/u2f_device.h

@@ -26,7 +26,7 @@ class U2fDevice {

};

using MessageCallback =

- base::Callback<void(U2fReturnCode, std::vector<uint8_t>)>;

+ base::Callback<void(U2fReturnCode, const std::vector<uint8_t>&)>;

using VersionCallback =

base::Callback<void(bool success, ProtocolVersion version)>;

using DeviceCallback =

« no previous file with comments | « no previous file | device/u2f/u2f_register.h » ('j') | no next file with comments »