device/u2f/u2f_sign.cc - Issue 2839043002: Pass u2f message callback vector as a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/u2f/u2f_sign.cc

Issue 2839043002: Pass u2f message callback vector as a const reference (Closed)

Patch Set: Change response callback to const ref Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/u2f/u2f_sign.cc

diff --git a/device/u2f/u2f_sign.cc b/device/u2f/u2f_sign.cc

index d537c4894e94f7aa05720ec220f0be2f5f0e81da..a1f5b7d3d5ae98edd49eb3b09e3a53a8962806d5 100644

--- a/device/u2f/u2f_sign.cc

+++ b/device/u2f/u2f_sign.cc

@@ -52,7 +52,7 @@ void U2fSign::TryDevice() {

void U2fSign::OnTryDevice(std::vector<std::vector<uint8_t>>::const_iterator it,

U2fReturnCode return_code,

- std::vector<uint8_t> response_data) {

+ const std::vector<uint8_t>& response_data) {

switch (return_code) {

case U2fReturnCode::SUCCESS:

state_ = State::COMPLETE;

« no previous file with comments | « device/u2f/u2f_sign.h ('k') | device/u2f/u2f_sign_unittest.cc » ('j') | no next file with comments »