device/u2f/u2f_sign.h - Issue 2839043002: Pass u2f message callback vector as a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/u2f/u2f_sign.h

Issue 2839043002: Pass u2f message callback vector as a const reference (Closed)

Patch Set: Change response callback to const ref Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/u2f/u2f_sign.h

diff --git a/device/u2f/u2f_sign.h b/device/u2f/u2f_sign.h

index e924137f81324e3a4d4ba05eafa602152379eac0..912fc77efa841d95b1f6d39bd283cf9e1a821d28 100644

--- a/device/u2f/u2f_sign.h

+++ b/device/u2f/u2f_sign.h

@@ -27,9 +27,9 @@ class U2fSign : public U2fRequest {

private:

void TryDevice() override;

- void OnTryDevice(std::vector<std::vector<uint8_t>>::const_iterator,

- U2fReturnCode,

- std::vector<uint8_t>);

+ void OnTryDevice(std::vector<std::vector<uint8_t>>::const_iterator it,

+ U2fReturnCode return_code,

+ const std::vector<uint8_t>& response_data);

const std::vector<std::vector<uint8_t>> registered_keys_;

std::vector<uint8_t> challenge_hash_;

« no previous file with comments | « device/u2f/u2f_request_unittest.cc ('k') | device/u2f/u2f_sign.cc » ('j') | no next file with comments »