Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2842003002: Reuse WeakFactory from U2fDevice derived classes (Closed)

Created:
3 years, 8 months ago by Casey Piper
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reuse WeakFactory from U2fDevice derived classes Rather than having a separate WeakPtrFactory, reuse the WeakPtrFactory from the derived classes when in the base U2fDevice class. BUG=686302 Review-Url: https://codereview.chromium.org/2842003002 Cr-Commit-Position: refs/heads/master@{#467079} Committed: https://chromium.googlesource.com/chromium/src/+/b112ae375080133ab52227c502e4c5b7bc541d03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M device/u2f/mock_u2f_device.h View 2 chunks +4 lines, -0 lines 0 comments Download
M device/u2f/mock_u2f_device.cc View 2 chunks +5 lines, -1 line 0 comments Download
M device/u2f/u2f_device.h View 2 chunks +1 line, -2 lines 0 comments Download
M device/u2f/u2f_device.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M device/u2f/u2f_hid_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/u2f/u2f_hid_device.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
Casey Piper
3 years, 8 months ago (2017-04-25 19:11:56 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-25 19:18:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842003002/1
3 years, 8 months ago (2017-04-25 19:44:19 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 19:51:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b112ae375080133ab52227c502e4...

Powered by Google App Engine
This is Rietveld 408576698