Removes ShellPort::IsRunningInMash()

Removes ShellPort::IsRunningInMash()

And converts to usage of Shell::GetAshConfig().

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2815043002
Cr-Commit-Position: refs/heads/master@{#464095}
Committed: https://chromium.googlesource.com/chromium/src/+/e5fd122629a18236e1458f79f0785a49ce0ab707

[sky, 2017-04-12 04:44:59]

For the most this is a straight rename. No doubt some of these conditionals will
need to change.

[sky, 2017-04-12 04:45:01]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:45:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 05:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 05:21:17]

Dry run: This issue passed the CQ dry run.

[msw, 2017-04-12 17:46:59]

lgtm with a q/nit.

https://codereview.chromium.org/2815043002/diff/20001/ash/shell.cc
File ash/shell.cc (left):

https://codereview.chromium.org/2815043002/diff/20001/ash/shell.cc#oldcode228
ash/shell.cc:228: instance_ = new
Shell(base::WrapUnique<ShellDelegate>(init_params.delegate),
q: Is there a reason for changing when Shell::instance_ is assigned in this CL?
It seems fine (nothing appears instantiate a Shell instance without calling
CreateInstance), but it seems slightly odd to include in this CL.

[sky, 2017-04-12 17:53:18]

https://codereview.chromium.org/2815043002/diff/20001/ash/shell.cc
File ash/shell.cc (left):

https://codereview.chromium.org/2815043002/diff/20001/ash/shell.cc#oldcode228
ash/shell.cc:228: instance_ = new
Shell(base::WrapUnique<ShellDelegate>(init_params.delegate),
On 2017/04/12 17:46:59, msw wrote:
> q: Is there a reason for changing when Shell::instance_ is assigned in this
CL?
> It seems fine (nothing appears instantiate a Shell instance without calling
> CreateInstance), but it seems slightly odd to include in this CL.

Ya, sorry, good question. The issue is that GetAshConfig() is called from the
constructor (line 575). But I think assigning instance_ in the constructor is a
bit risky. So, I changed the code back to what it was and in the constructor it
uses shell_port_->GetAshConfig() directly.

[sky, 2017-04-12 17:53:34]

The CQ bit was checked by sky@chromium.org

[sky, 2017-04-12 17:53:37]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2815043002/#ps40001
(title: "dont set instance_ in constructor")

[commit-bot: I haz the power, 2017-04-12 17:54:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-04-12 18:03:08]

still lgtm

https://codereview.chromium.org/2815043002/diff/20001/ash/shell.cc
File ash/shell.cc (left):

https://codereview.chromium.org/2815043002/diff/20001/ash/shell.cc#oldcode228
ash/shell.cc:228: instance_ = new
Shell(base::WrapUnique<ShellDelegate>(init_params.delegate),
On 2017/04/12 17:53:18, sky wrote:
> On 2017/04/12 17:46:59, msw wrote:
> > q: Is there a reason for changing when Shell::instance_ is assigned in this
> CL?
> > It seems fine (nothing appears instantiate a Shell instance without calling
> > CreateInstance), but it seems slightly odd to include in this CL.
> 
> Ya, sorry, good question. The issue is that GetAshConfig() is called from the
> constructor (line 575). But I think assigning instance_ in the constructor is
a
> bit risky. So, I changed the code back to what it was and in the constructor
it
> uses shell_port_->GetAshConfig() directly.

Gotcha.

[commit-bot: I haz the power, 2017-04-12 18:43:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492019614490880,
"parent_rev": "3980cdc0619f695e7359824c45063912eaa74bd8", "commit_rev":
"e5fd122629a18236e1458f79f0785a49ce0ab707"}

[commit-bot: I haz the power, 2017-04-12 18:44:57]

Description was changed from

==========
Removes ShellPort::IsRunningInMash()

And converts to usage of Shell::GetAshConfig().

BUG=687660
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Removes ShellPort::IsRunningInMash()

And converts to usage of Shell::GetAshConfig().

BUG=687660
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2815043002
Cr-Commit-Position: refs/heads/master@{#464095}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5fd122629a18236e1458f79f078...
==========

[commit-bot: I haz the power, 2017-04-12 18:44:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e5fd122629a18236e1458f79f078...