Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: ash/accelerators/accelerator_filter_unittest.cc

Issue 2815043002: Removes ShellPort::IsRunningInMash() (Closed)
Patch Set: dont set instance_ in constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/aura/shell_port_classic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/wm/core/accelerator_filter.h" 5 #include "ui/wm/core/accelerator_filter.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "ash/accelerators/accelerator_controller.h" 9 #include "ash/accelerators/accelerator_controller.h"
10 #include "ash/accelerators/accelerator_delegate.h" 10 #include "ash/accelerators/accelerator_delegate.h"
11 #include "ash/public/cpp/config.h"
11 #include "ash/public/cpp/shell_window_ids.h" 12 #include "ash/public/cpp/shell_window_ids.h"
12 #include "ash/session/session_controller.h" 13 #include "ash/session/session_controller.h"
13 #include "ash/shell.h" 14 #include "ash/shell.h"
14 #include "ash/shell_port.h"
15 #include "ash/test/ash_test_base.h" 15 #include "ash/test/ash_test_base.h"
16 #include "ash/test/ash_test_helper.h" 16 #include "ash/test/ash_test_helper.h"
17 #include "ash/test/test_screenshot_delegate.h" 17 #include "ash/test/test_screenshot_delegate.h"
18 #include "ash/wm/window_state.h" 18 #include "ash/wm/window_state.h"
19 #include "ash/wm/window_state_aura.h" 19 #include "ash/wm/window_state_aura.h"
20 #include "ash/wm/window_util.h" 20 #include "ash/wm/window_util.h"
21 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
22 #include "ui/aura/client/aura_constants.h" 22 #include "ui/aura/client/aura_constants.h"
23 #include "ui/aura/test/aura_test_base.h" 23 #include "ui/aura/test/aura_test_base.h"
24 #include "ui/aura/test/test_windows.h" 24 #include "ui/aura/test/test_windows.h"
25 #include "ui/aura/window.h" 25 #include "ui/aura/window.h"
26 #include "ui/base/accelerators/accelerator_history.h" 26 #include "ui/base/accelerators/accelerator_history.h"
27 #include "ui/events/event.h" 27 #include "ui/events/event.h"
28 #include "ui/events/test/event_generator.h" 28 #include "ui/events/test/event_generator.h"
29 #include "ui/gfx/geometry/rect.h" 29 #include "ui/gfx/geometry/rect.h"
30 30
31 namespace ash { 31 namespace ash {
32 namespace test { 32 namespace test {
33 33
34 typedef AshTestBase AcceleratorFilterTest; 34 typedef AshTestBase AcceleratorFilterTest;
35 35
36 // Tests if AcceleratorFilter works without a focused window. 36 // Tests if AcceleratorFilter works without a focused window.
37 TEST_F(AcceleratorFilterTest, TestFilterWithoutFocus) { 37 TEST_F(AcceleratorFilterTest, TestFilterWithoutFocus) {
38 // TODO: mash doesn't support ScreenshotDelgate yet. http://crbug.com/632111. 38 // TODO: mash doesn't support ScreenshotDelgate yet. http://crbug.com/632111.
39 if (ShellPort::Get()->IsRunningInMash()) 39 if (Shell::GetAshConfig() == Config::MASH)
40 return; 40 return;
41 41
42 const TestScreenshotDelegate* delegate = GetScreenshotDelegate(); 42 const TestScreenshotDelegate* delegate = GetScreenshotDelegate();
43 EXPECT_EQ(0, delegate->handle_take_screenshot_count()); 43 EXPECT_EQ(0, delegate->handle_take_screenshot_count());
44 44
45 ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow()); 45 ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
46 // AcceleratorController calls ScreenshotDelegate::HandleTakeScreenshot() when 46 // AcceleratorController calls ScreenshotDelegate::HandleTakeScreenshot() when
47 // VKEY_PRINT is pressed. See kAcceleratorData[] in accelerator_controller.cc. 47 // VKEY_PRINT is pressed. See kAcceleratorData[] in accelerator_controller.cc.
48 generator.PressKey(ui::VKEY_PRINT, 0); 48 generator.PressKey(ui::VKEY_PRINT, 0);
49 EXPECT_EQ(1, delegate->handle_take_screenshot_count()); 49 EXPECT_EQ(1, delegate->handle_take_screenshot_count());
50 generator.ReleaseKey(ui::VKEY_PRINT, 0); 50 generator.ReleaseKey(ui::VKEY_PRINT, 0);
51 EXPECT_EQ(1, delegate->handle_take_screenshot_count()); 51 EXPECT_EQ(1, delegate->handle_take_screenshot_count());
52 } 52 }
53 53
54 // Tests if AcceleratorFilter works as expected with a focused window. 54 // Tests if AcceleratorFilter works as expected with a focused window.
55 TEST_F(AcceleratorFilterTest, TestFilterWithFocus) { 55 TEST_F(AcceleratorFilterTest, TestFilterWithFocus) {
56 // TODO: mash doesn't support ScreenshotDelgate yet. http://crbug.com/632111. 56 // TODO: mash doesn't support ScreenshotDelgate yet. http://crbug.com/632111.
57 if (ShellPort::Get()->IsRunningInMash()) 57 if (Shell::GetAshConfig() == Config::MASH)
58 return; 58 return;
59 59
60 aura::test::TestWindowDelegate test_delegate; 60 aura::test::TestWindowDelegate test_delegate;
61 std::unique_ptr<aura::Window> window( 61 std::unique_ptr<aura::Window> window(
62 CreateTestWindowInShellWithDelegate(&test_delegate, -1, gfx::Rect())); 62 CreateTestWindowInShellWithDelegate(&test_delegate, -1, gfx::Rect()));
63 wm::ActivateWindow(window.get()); 63 wm::ActivateWindow(window.get());
64 64
65 const TestScreenshotDelegate* delegate = GetScreenshotDelegate(); 65 const TestScreenshotDelegate* delegate = GetScreenshotDelegate();
66 EXPECT_EQ(0, delegate->handle_take_screenshot_count()); 66 EXPECT_EQ(0, delegate->handle_take_screenshot_count());
67 67
68 // AcceleratorFilter should ignore the key events since the root window is 68 // AcceleratorFilter should ignore the key events since the root window is
69 // not focused. 69 // not focused.
70 ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow()); 70 ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
71 generator.PressKey(ui::VKEY_PRINT, 0); 71 generator.PressKey(ui::VKEY_PRINT, 0);
72 EXPECT_EQ(0, delegate->handle_take_screenshot_count()); 72 EXPECT_EQ(0, delegate->handle_take_screenshot_count());
73 generator.ReleaseKey(ui::VKEY_PRINT, 0); 73 generator.ReleaseKey(ui::VKEY_PRINT, 0);
74 EXPECT_EQ(0, delegate->handle_take_screenshot_count()); 74 EXPECT_EQ(0, delegate->handle_take_screenshot_count());
75 75
76 // Reset window before |test_delegate| gets deleted. 76 // Reset window before |test_delegate| gets deleted.
77 window.reset(); 77 window.reset();
78 } 78 }
79 79
80 // Tests if AcceleratorFilter ignores the flag for Caps Lock. 80 // Tests if AcceleratorFilter ignores the flag for Caps Lock.
81 TEST_F(AcceleratorFilterTest, TestCapsLockMask) { 81 TEST_F(AcceleratorFilterTest, TestCapsLockMask) {
82 // TODO: mash doesn't support ScreenshotDelgate yet. http://crbug.com/632111. 82 // TODO: mash doesn't support ScreenshotDelgate yet. http://crbug.com/632111.
83 if (ShellPort::Get()->IsRunningInMash()) 83 if (Shell::GetAshConfig() == Config::MASH)
84 return; 84 return;
85 85
86 const TestScreenshotDelegate* delegate = GetScreenshotDelegate(); 86 const TestScreenshotDelegate* delegate = GetScreenshotDelegate();
87 EXPECT_EQ(0, delegate->handle_take_screenshot_count()); 87 EXPECT_EQ(0, delegate->handle_take_screenshot_count());
88 88
89 ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow()); 89 ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
90 generator.PressKey(ui::VKEY_PRINT, 0); 90 generator.PressKey(ui::VKEY_PRINT, 0);
91 EXPECT_EQ(1, delegate->handle_take_screenshot_count()); 91 EXPECT_EQ(1, delegate->handle_take_screenshot_count());
92 generator.ReleaseKey(ui::VKEY_PRINT, 0); 92 generator.ReleaseKey(ui::VKEY_PRINT, 0);
93 EXPECT_EQ(1, delegate->handle_take_screenshot_count()); 93 EXPECT_EQ(1, delegate->handle_take_screenshot_count());
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 generator.PressKey(ui::VKEY_L, ui::EF_COMMAND_DOWN); 181 generator.PressKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
182 generator.ReleaseKey(ui::VKEY_L, ui::EF_COMMAND_DOWN); 182 generator.ReleaseKey(ui::VKEY_L, ui::EF_COMMAND_DOWN);
183 session_controller->FlushMojoForTest(); // LockScreen is an async mojo call. 183 session_controller->FlushMojoForTest(); // LockScreen is an async mojo call.
184 EXPECT_TRUE(session_controller->IsScreenLocked()); 184 EXPECT_TRUE(session_controller->IsScreenLocked());
185 UnblockUserSession(); 185 UnblockUserSession();
186 EXPECT_FALSE(session_controller->IsScreenLocked()); 186 EXPECT_FALSE(session_controller->IsScreenLocked());
187 } 187 }
188 188
189 } // namespace test 189 } // namespace test
190 } // namespace ash 190 } // namespace ash
OLDNEW
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/aura/shell_port_classic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698