Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: ash/shelf/shelf_window_watcher_unittest.cc

Issue 2815043002: Removes ShellPort::IsRunningInMash() (Closed)
Patch Set: dont set instance_ in constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_window_watcher.cc ('k') | ash/shelf/wm_shelf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_window_watcher_unittest.cc
diff --git a/ash/shelf/shelf_window_watcher_unittest.cc b/ash/shelf/shelf_window_watcher_unittest.cc
index 1d5ad61aafe52350f494d836d9e8bb889461276d..1319f4b98a981f32c469cfe9a3ee0b00f3a4c8dc 100644
--- a/ash/shelf/shelf_window_watcher_unittest.cc
+++ b/ash/shelf/shelf_window_watcher_unittest.cc
@@ -4,6 +4,7 @@
#include "ash/shelf/shelf_window_watcher.h"
+#include "ash/public/cpp/config.h"
#include "ash/public/cpp/shelf_item.h"
#include "ash/public/cpp/shell_window_ids.h"
#include "ash/public/cpp/window_properties.h"
@@ -75,7 +76,7 @@ TEST_F(ShelfWindowWatcherTest, OpenAndClose) {
TEST_F(ShelfWindowWatcherTest, CreateAndRemoveShelfItemProperties) {
// TODO: investigate failure in mash. http://crbug.com/695562.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
// ShelfModel only has an APP_LIST item.
@@ -119,7 +120,7 @@ TEST_F(ShelfWindowWatcherTest, CreateAndRemoveShelfItemProperties) {
TEST_F(ShelfWindowWatcherTest, ActivateWindow) {
// TODO: investigate failure in mash. http://crbug.com/695562.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
// ShelfModel only have APP_LIST item.
@@ -157,7 +158,7 @@ TEST_F(ShelfWindowWatcherTest, ActivateWindow) {
TEST_F(ShelfWindowWatcherTest, UpdateWindowProperty) {
// TODO: investigate failure in mash. http://crbug.com/695562.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
// ShelfModel only has an APP_LIST item.
@@ -186,7 +187,7 @@ TEST_F(ShelfWindowWatcherTest, UpdateWindowProperty) {
TEST_F(ShelfWindowWatcherTest, MaximizeAndRestoreWindow) {
// TODO: investigate failure in mash. http://crbug.com/695562.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
// ShelfModel only has an APP_LIST item.
@@ -228,7 +229,7 @@ TEST_F(ShelfWindowWatcherTest, MaximizeAndRestoreWindow) {
// TODO(simonhong): Add a test for removing a Window during the dragging.
TEST_F(ShelfWindowWatcherTest, DragWindow) {
// TODO: investigate failure in mash. http://crbug.com/695562.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
// ShelfModel only has an APP_LIST item.
@@ -260,7 +261,7 @@ TEST_F(ShelfWindowWatcherTest, DragWindow) {
// Ensure shelf items are added and removed as panels are opened and closed.
TEST_F(ShelfWindowWatcherTest, PanelWindow) {
// TODO: investigate failure in mash. http://crbug.com/695562.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
// ShelfModel only has an APP_LIST item.
« no previous file with comments | « ash/shelf/shelf_window_watcher.cc ('k') | ash/shelf/wm_shelf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698