Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2694)

Unified Diff: ash/wm/system_modal_container_layout_manager_unittest.cc

Issue 2815043002: Removes ShellPort::IsRunningInMash() (Closed)
Patch Set: dont set instance_ in constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/system_modal_container_layout_manager.cc ('k') | ash/wm/toplevel_window_event_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/system_modal_container_layout_manager_unittest.cc
diff --git a/ash/wm/system_modal_container_layout_manager_unittest.cc b/ash/wm/system_modal_container_layout_manager_unittest.cc
index bc3a0ac4f229ad524de369b4979b7a18562b78e8..70146ee62ca03ff256fc1f6545f9cae864eeb034 100644
--- a/ash/wm/system_modal_container_layout_manager_unittest.cc
+++ b/ash/wm/system_modal_container_layout_manager_unittest.cc
@@ -6,6 +6,7 @@
#include <memory>
+#include "ash/public/cpp/config.h"
#include "ash/public/cpp/shell_window_ids.h"
#include "ash/root_window_controller.h"
#include "ash/session/session_state_delegate.h"
@@ -153,7 +154,7 @@ class SystemModalContainerLayoutManagerTest : public AshTestBase {
keyboard::switches::kEnableVirtualKeyboard);
AshTestBase::SetUp();
// TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
- if (!ShellPort::Get()->IsRunningInMash()) {
+ if (Shell::GetAshConfig() != Config::MASH) {
Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
keyboard::KeyboardController::GetInstance());
}
@@ -161,7 +162,7 @@ class SystemModalContainerLayoutManagerTest : public AshTestBase {
void TearDown() override {
// TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
- if (!ShellPort::Get()->IsRunningInMash()) {
+ if (Shell::GetAshConfig() != Config::MASH) {
Shell::GetPrimaryRootWindowController()->DeactivateKeyboard(
keyboard::KeyboardController::GetInstance());
}
@@ -662,7 +663,7 @@ TEST_F(SystemModalContainerLayoutManagerTest, MultiDisplays) {
TEST_F(SystemModalContainerLayoutManagerTest,
SystemModalDialogGetPushedFromKeyboard) {
// TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
const gfx::Rect& container_bounds = GetModalContainer()->bounds();
@@ -702,7 +703,7 @@ TEST_F(SystemModalContainerLayoutManagerTest,
TEST_F(SystemModalContainerLayoutManagerTest,
SystemModalDialogGetPushedButNotCroppedFromKeyboard) {
// TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
const gfx::Rect& container_bounds = GetModalContainer()->bounds();
@@ -739,7 +740,7 @@ TEST_F(SystemModalContainerLayoutManagerTest,
TEST_F(SystemModalContainerLayoutManagerTest,
SystemModalDialogGetPushedButNotCroppedFromKeyboardIfNotCentered) {
// TODO: mash doesn't support virtual keyboard. http://crbug.com/698892.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
const gfx::Size screen_size = Shell::GetPrimaryRootWindow()->bounds().size();
« no previous file with comments | « ash/wm/system_modal_container_layout_manager.cc ('k') | ash/wm/toplevel_window_event_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698