Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc

Issue 2815043002: Removes ShellPort::IsRunningInMash() (Closed)
Patch Set: dont set instance_ in constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/screen_util_unittest.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc
diff --git a/ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc b/ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc
index 40a1f9d9ea06ae5f17b0d67614033ab33d76184b..b85266b2672080077cdb50bcca3e00c0daa6120a 100644
--- a/ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc
+++ b/ash/shelf/shelf_button_pressed_metric_tracker_unittest.cc
@@ -6,8 +6,9 @@
#include <utility>
+#include "ash/public/cpp/config.h"
#include "ash/shelf/wm_shelf.h"
-#include "ash/shell_port.h"
+#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/shelf_button_pressed_metric_tracker_test_api.h"
#include "ash/test/shelf_view_test_api.h"
@@ -155,7 +156,7 @@ void ShelfButtonPressedMetricTrackerTest::ButtonPressed(
TEST_F(ShelfButtonPressedMetricTrackerTest,
Launcher_ButtonPressed_MouseIsRecordedWhenIconActivatedByMouse) {
// TODO: investigate failure in mash. http://crbug.com/695565.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
const ui::MouseEvent mouse_event(ui::ET_MOUSE_PRESSED, gfx::Point(),
@@ -172,7 +173,7 @@ TEST_F(ShelfButtonPressedMetricTrackerTest,
TEST_F(ShelfButtonPressedMetricTrackerTest,
Launcher_ButtonPressed_MouseIsRecordedWhenIconActivatedByTouch) {
// TODO: investigate failure in mash. http://crbug.com/695565.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
const ui::TouchEvent touch_event(
@@ -190,7 +191,7 @@ TEST_F(ShelfButtonPressedMetricTrackerTest,
TEST_F(ShelfButtonPressedMetricTrackerTest,
Launcher_LaunchTaskIsRecordedWhenNewWindowIsCreated) {
// TODO: investigate failure in mash. http://crbug.com/695565.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
base::UserActionTester user_action_tester;
@@ -203,7 +204,7 @@ TEST_F(ShelfButtonPressedMetricTrackerTest,
TEST_F(ShelfButtonPressedMetricTrackerTest,
Launcher_MinimizeTaskIsRecordedWhenWindowIsMinimized) {
// TODO: investigate failure in mash. http://crbug.com/695565.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
base::UserActionTester user_action_tester;
@@ -216,7 +217,7 @@ TEST_F(ShelfButtonPressedMetricTrackerTest,
TEST_F(ShelfButtonPressedMetricTrackerTest,
Launcher_SwitchTaskIsRecordedWhenExistingWindowIsActivated) {
// TODO: investigate failure in mash. http://crbug.com/695565.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
base::UserActionTester user_action_tester;
« no previous file with comments | « ash/screen_util_unittest.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698