Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: ash/root_window_controller_unittest.cc

Issue 2815043002: Removes ShellPort::IsRunningInMash() (Closed)
Patch Set: dont set instance_ in constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/root_window_controller.cc ('k') | ash/rotator/screen_rotation_animator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller_unittest.cc
diff --git a/ash/root_window_controller_unittest.cc b/ash/root_window_controller_unittest.cc
index ce3611c8d7ea754a08cdcbf2208e7cc748b7d8b8..3671f30b9ce7eb6b00706bdfeec8e5b62947154f 100644
--- a/ash/root_window_controller_unittest.cc
+++ b/ash/root_window_controller_unittest.cc
@@ -6,6 +6,7 @@
#include <memory>
+#include "ash/public/cpp/config.h"
#include "ash/public/cpp/shell_window_ids.h"
#include "ash/session/session_controller.h"
#include "ash/shell.h"
@@ -186,7 +187,7 @@ TEST_F(RootWindowControllerTest, MoveWindows_Basic) {
EXPECT_EQ(root_windows[1], panel->GetRootWindow());
EXPECT_EQ(kShellWindowId_PanelContainer, panel->parent()->id());
- if (ShellPort::Get()->IsRunningInMash()) {
+ if (Shell::GetAshConfig() == Config::MASH) {
// TODO(erg): Ignore this one part of the test when running mash. We would
// crash because the aura::Window |d2| created in the other block doesn't
// get deleted, and thus continues to contain a reference to its delegate,
@@ -302,7 +303,7 @@ TEST_F(RootWindowControllerTest, MoveWindows_Modal) {
// Make sure lock related windows moves.
TEST_F(RootWindowControllerTest, MoveWindows_LockWindowsInUnified) {
// TODO: requires unified desktop mode. http://crbug.com/581462.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
display_manager()->SetUnifiedDesktopEnabled(true);
@@ -763,7 +764,7 @@ TEST_F(VirtualKeyboardRootWindowControllerTest,
TEST_F(VirtualKeyboardRootWindowControllerTest,
VirtualKeyboardOnTouchableDisplayOnly) {
// TODO: investigate failure in mash. http://crbug.com/695640.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
UpdateDisplay("500x500,500x500");
@@ -815,7 +816,7 @@ TEST_F(VirtualKeyboardRootWindowControllerTest,
// virtual keyboard follows the input focus.
TEST_F(VirtualKeyboardRootWindowControllerTest, FollowInputFocus) {
// TODO: investigate failure in mash. http://crbug.com/695640.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
UpdateDisplay("500x500,500x500");
@@ -885,7 +886,7 @@ TEST_F(VirtualKeyboardRootWindowControllerTest, FollowInputFocus) {
TEST_F(VirtualKeyboardRootWindowControllerTest,
VirtualKeyboardShowOnSpecifiedDisplay) {
// TODO: fails in mash. http://crbug.com/695640.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
UpdateDisplay("500x500,500x500");
@@ -1082,7 +1083,7 @@ TEST_F(VirtualKeyboardRootWindowControllerTest, EnsureCaretInWorkArea) {
TEST_F(VirtualKeyboardRootWindowControllerTest,
EnsureCaretInWorkAreaWithMultipleDisplays) {
// TODO: fails in mash. http://crbug.com/695640.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
UpdateDisplay("500x500,600x600");
« no previous file with comments | « ash/root_window_controller.cc ('k') | ash/rotator/screen_rotation_animator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698