Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: ash/wm/window_manager_unittest.cc

Issue 2815043002: Removes ShellPort::IsRunningInMash() (Closed)
Patch Set: dont set instance_ in constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/window_cycle_controller_unittest.cc ('k') | ash/wm/workspace/workspace_event_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_manager_unittest.cc
diff --git a/ash/wm/window_manager_unittest.cc b/ash/wm/window_manager_unittest.cc
index 52c06a188543368460badf5a0c810b55d43aae22..69647c37d7ca436e5841030e28f0df26cc2fa5aa 100644
--- a/ash/wm/window_manager_unittest.cc
+++ b/ash/wm/window_manager_unittest.cc
@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "ash/public/cpp/config.h"
#include "ash/public/cpp/shell_window_ids.h"
#include "ash/shell.h"
-#include "ash/shell_port.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/test_activation_delegate.h"
#include "ash/wm/window_util.h"
@@ -469,7 +469,7 @@ TEST_F(WindowManagerTest, ActivateOnTouch) {
TEST_F(WindowManagerTest, MouseEventCursors) {
// TODO: investigate failure in mash. http://crbug.com/698895.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
aura::Window* root_window = Shell::GetPrimaryRootWindow();
@@ -708,7 +708,7 @@ TEST_F(WindowManagerTest, AdditionalFilters) {
// Touch visually hides the cursor.
TEST_F(WindowManagerTest, UpdateCursorVisibility) {
// TODO: mash doesn't support CursorManager. http://crbug.com/631103.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
ui::test::EventGenerator& generator = GetEventGenerator();
@@ -731,7 +731,7 @@ TEST_F(WindowManagerTest, UpdateCursorVisibility) {
// Cursor is hidden on keypress.
TEST_F(WindowManagerTest, UpdateCursorVisibilityOnKeyEvent) {
// TODO: mash doesn't support CursorManager. http://crbug.com/631103.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
ui::test::EventGenerator& generator = GetEventGenerator();
@@ -755,7 +755,7 @@ TEST_F(WindowManagerTest, UpdateCursorVisibilityOnKeyEvent) {
// Test that pressing an accelerator does not hide the cursor.
TEST_F(WindowManagerTest, UpdateCursorVisibilityAccelerator) {
// TODO: mash doesn't support CursorManager. http://crbug.com/631103.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
ui::test::EventGenerator& generator = GetEventGenerator();
@@ -780,7 +780,7 @@ TEST_F(WindowManagerTest, UpdateCursorVisibilityAccelerator) {
TEST_F(WindowManagerTest, TestCursorClientObserver) {
// TODO: mash doesn't support CursorManager. http://crbug.com/631103.
- if (ShellPort::Get()->IsRunningInMash())
+ if (Shell::GetAshConfig() == Config::MASH)
return;
ui::test::EventGenerator& generator = GetEventGenerator();
« no previous file with comments | « ash/wm/window_cycle_controller_unittest.cc ('k') | ash/wm/workspace/workspace_event_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698