Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2811793004: Rename EqualIgnoringCase*() to DeprecatedEqualIgnoringCase*() (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
Yuta Kitamura
CC:
ajuma+watch-canvas_chromium.org, ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, fs, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, gasubic, haraken, iclelland, Nate Chapin, Justin Novosad, kenneth.christiansen, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, loading-reviews+parser_chromium.org, lunalu1, lushnikov+blink_chromium.org, mac-reviews_chromium.org, mlamouri+watch-blink_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sof, nessy, Srirama, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename EqualIgnoringCase*() to DeprecatedEqualIgnoringCase*() These functions are confusing, and are misused frequently. BUG=627682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2811793004 Cr-Commit-Position: refs/heads/master@{#463547} Committed: https://chromium.googlesource.com/chromium/src/+/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -448 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/AttributeCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 5 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SandboxFlags.cpp View 1 chunk +17 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SmartClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSource.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 5 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/CrossOriginAttribute.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBRElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDivElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 17 chunks +41 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLHRElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLIElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMetaElement.cpp View 5 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLParagraphElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLParamElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 3 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLUListElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttribute.cpp View 1 chunk +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/HiddenInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/NumberInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLElementStack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/ContextMenuController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/AlternateFontFamily.h View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFaceCreationParams.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchUtils.cpp View 5 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/network/EncodedFormData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleWin.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringBuilder.h View 1 chunk +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringHash.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringImpl.h View 1 chunk +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp View 5 chunks +35 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringView.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringView.cpp View 1 chunk +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/WTFString.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
yutak@, would you review this please?
3 years, 8 months ago (2017-04-11 01:13:25 UTC) #7
Yuta Kitamura
lgtm
3 years, 8 months ago (2017-04-11 05:09:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811793004/1
3 years, 8 months ago (2017-04-11 06:03:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5
3 years, 8 months ago (2017-04-11 06:12:46 UTC) #13
findit-for-me
3 years, 8 months ago (2017-04-11 08:18:39 UTC) #14
Message was sent while issue was closed.
Findit identified this CL at revision 463547 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698