Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/platform/wtf/text/StringBuilder.h

Issue 2811793004: Rename EqualIgnoringCase*() to DeprecatedEqualIgnoringCase*() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/wtf/text/StringBuilder.h
diff --git a/third_party/WebKit/Source/platform/wtf/text/StringBuilder.h b/third_party/WebKit/Source/platform/wtf/text/StringBuilder.h
index c9ae4b35a095ca2333708e5134061f5620a80a70..20e174565f4619047dcb42ac5b8b3babbaa2b77e 100644
--- a/third_party/WebKit/Source/platform/wtf/text/StringBuilder.h
+++ b/third_party/WebKit/Source/platform/wtf/text/StringBuilder.h
@@ -235,24 +235,27 @@ bool Equal(const StringBuilder& s, const CharType* buffer, unsigned length) {
}
template <typename CharType>
-bool EqualIgnoringCase(const StringBuilder& s,
- const CharType* buffer,
- unsigned length) {
+bool DeprecatedEqualIgnoringCase(const StringBuilder& s,
+ const CharType* buffer,
+ unsigned length) {
if (s.length() != length)
return false;
if (s.Is8Bit())
- return EqualIgnoringCase(s.Characters8(), buffer, length);
+ return DeprecatedEqualIgnoringCase(s.Characters8(), buffer, length);
- return EqualIgnoringCase(s.Characters16(), buffer, length);
+ return DeprecatedEqualIgnoringCase(s.Characters16(), buffer, length);
}
// Unicode aware case insensitive string matching. Non-ASCII characters might
// match to ASCII characters. This function is rarely used to implement web
// platform features.
-inline bool EqualIgnoringCase(const StringBuilder& s, const char* string) {
- return EqualIgnoringCase(s, reinterpret_cast<const LChar*>(string),
- strlen(string));
+// This function is deprecated. We should introduce EqualIgnoringASCIICase() or
+// EqualIgnoringUnicodeCase(). See crbug.com/627682
+inline bool DeprecatedEqualIgnoringCase(const StringBuilder& s,
+ const char* string) {
+ return DeprecatedEqualIgnoringCase(s, reinterpret_cast<const LChar*>(string),
+ strlen(string));
}
template <typename StringType>
« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleWin.cpp ('k') | third_party/WebKit/Source/platform/wtf/text/StringHash.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698