bindings: Pass is_null flag to attribute setters when they are nullable

bindings: Pass is_null flag to attribute setters when they are nullable

Some types can express null by itself (e.g. pointers) but some others
are not (e.g. bool). Ideally we should wrap these types with Nullable<T>
to make it nullable. However, changing to use Nullable<T> requires a lot
of changes in the binding layer. As a workaround, use a flag to indicate
it is null or not.

BUG=709833
Review-Url: https://codereview.chromium.org/2809543002
Cr-Commit-Position: refs/heads/master@{#463169}
Committed: https://chromium.googlesource.com/chromium/src/+/b4de20aaeabfe3d6476d9d431992079c9d09486a

[bashi, 2017-04-10 00:46:40]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 00:46:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-04-10 02:29:45]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2017-04-10 02:29:46]

PTAL.

Context: https://codereview.chromium.org/2805493002/#msg15

[haraken, 2017-04-10 02:38:40]

Yeah, it looks nasty to use an is_null flag but it looks like we're already
using the flag in v8_attributes.py.

LGTM.

[commit-bot: I haz the power, 2017-04-10 02:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 02:43:02]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-04-10 02:58:04]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-04-10 02:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 03:03:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491793084848210, "parent_rev":
"7dfe5a09c6622a2079b5cc94cfc0cd565e1c0601", "commit_rev":
"2706dffc8735c6bc58b71b48a86c81b8792d8e6c"}

[commit-bot: I haz the power, 2017-04-10 03:09:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491793084848210, "parent_rev":
"dae88df073f5e90c852f29b80e46224273098cd7", "commit_rev":
"b4de20aaeabfe3d6476d9d431992079c9d09486a"}

[commit-bot: I haz the power, 2017-04-10 03:11:00]

Description was changed from

==========
bindings: Pass is_null flag to attribute setters when they are nullable

Some types can express null by itself (e.g. pointers) but some others
are not (e.g. bool). Ideally we should wrap these types with Nullable<T>
to make it nullable. However, changing to use Nullable<T> requires a lot
of changes in the binding layer. As a workaround, use a flag to indicate
it is null or not.

BUG=709833
==========

to

==========
bindings: Pass is_null flag to attribute setters when they are nullable

Some types can express null by itself (e.g. pointers) but some others
are not (e.g. bool). Ideally we should wrap these types with Nullable<T>
to make it nullable. However, changing to use Nullable<T> requires a lot
of changes in the binding layer. As a workaround, use a flag to indicate
it is null or not.

BUG=709833

Review-Url: https://codereview.chromium.org/2809543002
Cr-Commit-Position: refs/heads/master@{#463169}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4de20aaeabfe3d6476d9d431992...
==========

[commit-bot: I haz the power, 2017-04-10 03:11:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4de20aaeabfe3d6476d9d431992...