third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index e3eb374a3031ad02d7f4f1975b4a725ffad17303..ecc6277fdad954aa8a483b724019efb5c47e2a87 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -460,6 +460,8 @@ def setter_expression(interface, attribute, context):

'kListenerFindOrCreate)')

else:

arguments.append('cppValue')

+ if idl_type.is_explicit_nullable:

+ arguments.append('isNull')

if context['is_setter_raises_exception']:

arguments.append('exceptionState')

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl » ('j') | no next file with comments »