Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index 1686fdbcaa05962f51cfd8e02662bd37347bede2..22e11982268c4e0fbbf50f7e0238d99cd79eedde 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -576,6 +576,7 @@ String HTMLInputElement::selectionDirectionForBinding(
void HTMLInputElement::setSelectionStartForBinding(
unsigned start,
+ bool is_null,
ExceptionState& exception_state) {
if (!input_type_->SupportsSelectionAPI()) {
exception_state.ThrowDOMException(kInvalidStateError,
@@ -589,6 +590,7 @@ void HTMLInputElement::setSelectionStartForBinding(
void HTMLInputElement::setSelectionEndForBinding(
unsigned end,
+ bool is_null,
ExceptionState& exception_state) {
if (!input_type_->SupportsSelectionAPI()) {
exception_state.ThrowDOMException(kInvalidStateError,
@@ -1130,6 +1132,7 @@ double HTMLInputElement::valueAsDate(bool& is_null) const {
}
void HTMLInputElement::setValueAsDate(double value,
+ bool is_null,
ExceptionState& exception_state) {
input_type_->SetValueAsDate(value, exception_state);
}

Powered by Google App Engine
This is Rietveld 408576698