third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h - Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h

Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h

index 7b18ea4025b024b548692796c7648c6654c84df9..39b5333fbaf15ba943d0baf0761a26bf37c86d34 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h

@@ -175,6 +175,8 @@ class V8TestObject {

CORE_EXPORT static void stringFrozenArrayAttributeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

CORE_EXPORT static void testInterfaceEmptyFrozenArrayAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

CORE_EXPORT static void testInterfaceEmptyFrozenArrayAttributeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

+ CORE_EXPORT static void booleanOrNullAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

+ CORE_EXPORT static void booleanOrNullAttributeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

CORE_EXPORT static void stringOrNullAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

CORE_EXPORT static void stringOrNullAttributeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);

CORE_EXPORT static void longOrNullAttributeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);