Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp

Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp b/third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp
index 1c0ccda28a9e82881e83d6fd04c288ac6c45ca63..9e05e04559bee8a026e0f209bff6e09cb711e75e 100644
--- a/third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp
+++ b/third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp
@@ -275,15 +275,15 @@ TEST_F(AnimationAnimationTimelineTest, SetCurrentTime) {
EXPECT_EQ(200, timeline->CurrentTimeInternal());
EXPECT_EQ(zero_time, timeline->ZeroTime());
- timeline->setCurrentTime(0);
+ timeline->setCurrentTime(0, false);
EXPECT_EQ(0, timeline->currentTime());
EXPECT_EQ(zero_time + 200, timeline->ZeroTime());
- timeline->setCurrentTime(1000);
+ timeline->setCurrentTime(1000, false);
EXPECT_EQ(1000, timeline->currentTime());
EXPECT_EQ(zero_time + 199, timeline->ZeroTime());
- timeline->setCurrentTime(2000);
+ timeline->setCurrentTime(2000, false);
EXPECT_EQ(2000, timeline->currentTime());
EXPECT_EQ(zero_time + 198, timeline->ZeroTime());
}
@@ -338,7 +338,7 @@ TEST_F(AnimationAnimationTimelineTest, UseAnimationAfterTimelineDeref) {
Animation* animation = timeline->Play(0);
timeline.Clear();
// Test passes if this does not crash.
- animation->setStartTime(0);
+ animation->setStartTime(0, false);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698