Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2809543002: bindings: Pass is_null flag to attribute setters when they are nullable (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h
index efa9d5ec0ef44e9bc1681c8431c7a29dea860668..8c8e6fe7328f2b002ca3bc6529044a08d31787e4 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h
@@ -144,7 +144,7 @@ class CORE_EXPORT HTMLInputElement : public TextControlElement {
void SetEditingValue(const String&);
double valueAsDate(bool& is_null) const;
- void setValueAsDate(double, ExceptionState&);
+ void setValueAsDate(double, bool is_null, ExceptionState&);
double valueAsNumber() const;
void setValueAsNumber(double,
@@ -161,8 +161,8 @@ class CORE_EXPORT HTMLInputElement : public TextControlElement {
unsigned selectionStartForBinding(bool&, ExceptionState&) const;
unsigned selectionEndForBinding(bool&, ExceptionState&) const;
String selectionDirectionForBinding(ExceptionState&) const;
- void setSelectionStartForBinding(unsigned, ExceptionState&);
- void setSelectionEndForBinding(unsigned, ExceptionState&);
+ void setSelectionStartForBinding(unsigned, bool is_null, ExceptionState&);
+ void setSelectionEndForBinding(unsigned, bool is_null, ExceptionState&);
void setSelectionDirectionForBinding(const String&, ExceptionState&);
void setSelectionRangeForBinding(unsigned start,
unsigned end,

Powered by Google App Engine
This is Rietveld 408576698