Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all support for cygwin in run-webkit-tests. BUG=610614 Review-Url: https://codereview.chromium.org/2799713002 Cr-Commit-Position: refs/heads/master@{#462566} Committed: https://chromium.googlesource.com/chromium/src/+/d04df31fccaf2a270f6cd30300cf99b6131625e5

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -270 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 7 chunks +20 lines, -44 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/path.py View 3 chunks +1 line, -73 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py View 2 chunks +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_mock.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py View 4 chunks +4 lines, -18 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 7 chunks +5 lines, -27 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 4 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 5 chunks +17 lines, -31 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
qyearsley
3 years, 8 months ago (2017-04-05 20:50:01 UTC) #3
Dirk Pranke
this mostly looks good, but it looks like uploading the patch didn't quite work right ...
3 years, 8 months ago (2017-04-06 01:02:41 UTC) #7
qyearsley
On 2017/04/06 at 01:02:41, dpranke wrote: > this mostly looks good, but it looks like ...
3 years, 8 months ago (2017-04-06 01:21:09 UTC) #8
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-06 03:03:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799713002/20001
3 years, 8 months ago (2017-04-06 16:42:48 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:58:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d04df31fccaf2a270f6cd30300cf...

Powered by Google App Engine
This is Rietveld 408576698