Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
index 699a026a2a9fd5033f3ab7d2de5c50652e998495..b180ca9a3c88a01d39da160cda8e11a9c0ae10d7 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py
@@ -39,12 +39,6 @@ class AbspathTest(unittest.TestCase):
def platform_info(self):
return SystemHost().platform
- def test_abspath_to_uri_cygwin(self):
- if sys.platform != 'cygwin':
- return
- self.assertEqual(path.abspath_to_uri(self.platform_info(), '/cygdrive/c/foo/bar.html'),
- 'file:///C:/foo/bar.html')
-
def test_abspath_to_uri_unixy(self):
self.assertEqual(path.abspath_to_uri(MockPlatformInfo(), '/foo/bar.html'),
'file:///foo/bar.html')
@@ -58,24 +52,3 @@ class AbspathTest(unittest.TestCase):
def test_abspath_to_uri_escaping_unixy(self):
self.assertEqual(path.abspath_to_uri(MockPlatformInfo(), '/foo/bar + baz%?.html'),
'file:///foo/bar%20+%20baz%25%3F.html')
-
- # Note that you can't have '?' in a filename on windows.
- def test_abspath_to_uri_escaping_cygwin(self):
- if sys.platform != 'cygwin':
- return
- self.assertEqual(path.abspath_to_uri(self.platform_info(), '/cygdrive/c/foo/bar + baz%.html'),
- 'file:///C:/foo/bar%20+%20baz%25.html')
-
- def test_stop_cygpath_subprocess(self):
- if sys.platform != 'cygwin':
- return
-
- # Call cygpath to ensure the subprocess is running.
- path.cygpath('/cygdrive/c/foo.txt')
- self.assertTrue(path._CygPath._singleton.is_running())
-
- # Stop it.
- path._CygPath.stop_cygpath_subprocess()
-
- # Ensure that it is stopped.
- self.assertFalse(path._CygPath._singleton.is_running())

Powered by Google App Engine
This is Rietveld 408576698