Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
index ff36290b2af86562b40672ef34add0e845892fdd..a1e239a10eb6b5cab62cad497dfe71ad98764955 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
@@ -122,13 +122,6 @@ class TestPlatformInfo(unittest.TestCase):
self.assertTrue(info.is_win())
self.assertFalse(info.is_freebsd())
- info = self.make_info(fake_sys('cygwin'), executive=fake_executive('6.1.7600'))
- self.assertEqual(info.os_name, 'win')
- self.assertFalse(info.is_linux())
- self.assertFalse(info.is_mac())
- self.assertTrue(info.is_win())
- self.assertFalse(info.is_freebsd())
-
info = self.make_info(fake_sys('freebsd8'))
self.assertEqual(info.os_name, 'freebsd')
self.assertFalse(info.is_linux())
@@ -168,14 +161,6 @@ class TestPlatformInfo(unittest.TestCase):
executive=fake_executive('5.0.1234'))
self.assertRaises(AssertionError, self.make_info, fake_sys('win32'),
executive=fake_executive('6.1.1234'))
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('10.1.1234')).os_version, 'future')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('10.0.1234')).os_version, '10')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('6.3.1234')).os_version, '8.1')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('6.2.1234')).os_version, '8')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('6.1.7601')).os_version, '7sp1')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('6.1.7600')).os_version, '7sp0')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('6.0.1234')).os_version, 'vista')
- self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('5.1.1234')).os_version, 'xp')
def _assert_file_implies_linux_distribution(self, file_path, distribution):
info = self.make_info(sys_module=fake_sys('linux2'), filesystem_module=MockFileSystem({file_path: ''}))
@@ -187,9 +172,6 @@ class TestPlatformInfo(unittest.TestCase):
self._assert_file_implies_linux_distribution('/etc/redhat-release', 'redhat')
self._assert_file_implies_linux_distribution('/etc/mock-release', 'unknown')
- info = self.make_info(fake_sys('cygwin'), executive=fake_executive('6.1.7600'))
- self.assertIsNone(info.linux_distribution())
-
def test_display_name(self):
info = self.make_info(fake_sys('darwin'))
self.assertNotEquals(info.display_name(), '')
@@ -215,3 +197,7 @@ class TestPlatformInfo(unittest.TestCase):
info = self.make_info(fake_sys('freebsd9'))
self.assertIsNone(info.total_bytes_memory())
+
+ def test_unsupported_platform(self):
+ with self.assertRaises(AssertionError):
+ self.make_info(fake_sys('cygwin'))

Powered by Google App Engine
This is Rietveld 408576698