Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
index 883aaf7a08011ecddf45ab31c88adde27437397d..3c7c8eacc34f429223482e76ac831742c5106417 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py
@@ -159,19 +159,12 @@ class WinPort(base.Port):
# FIXME: This is a temporary hack to get the cr-win bot online until
# someone from the cr-win port can take a look.
+ # TODO(qyearsley): Remove this in a separate CL.
apache_envvars = ['SYSTEMDRIVE', 'SYSTEMROOT', 'TEMP', 'TMP']
for key, value in self.host.environ.copy().items():
if key not in env and key in apache_envvars:
env[key] = value
- # Put the cygwin directory first in the path to find cygwin1.dll.
- env['PATH'] = '%s;%s' % (self.path_from_chromium_base('third_party', 'cygwin', 'bin'), env['PATH'])
- # Configure the cygwin directory so that pywebsocket finds proper
- # python executable to run cgi program.
- env['CYGWIN_PATH'] = self.path_from_chromium_base('third_party', 'cygwin', 'bin')
- if self.get_option('register_cygwin'):
- setup_mount = self.path_from_chromium_base('third_party', 'cygwin', 'setup_mount.bat')
- self._executive.run_command([setup_mount]) # Paths are all absolute, so this does not require a cwd.
return env
def check_build(self, needs_http, printer):

Powered by Google App Engine
This is Rietveld 408576698