third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py - Issue 2799713002: Remove all support for cygwin in run-webkit-tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py

index acb9b0217dd10c91846c96b89de5b34b060ccb81..6854863da15eb823aa38f31618b4ff6b0342dfdc 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py

@@ -39,7 +39,7 @@ class TestCrashService(unittest.TestCase):

def test_start_cmd(self):

# Fails on win - see https://bugs.webkit.org/show_bug.cgi?id=84726

- if sys.platform in ('cygwin', 'win32'):

+ if sys.platform == 'win32':

return

host = MockHost()

@@ -55,7 +55,6 @@ class TestCrashService(unittest.TestCase):

test_port._path_to_crash_service = lambda: "/mock/crash_service"

host.platform.is_win = lambda: True

- host.platform.is_cygwin = lambda: False

server = CrashService(test_port, "/mock/crash_dumps_dir")

server._check_that_all_ports_are_available = lambda: True