third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py - Issue 2799713002: Remove all support for cygwin in run-webkit-tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py

index 9090224ca645a65a149864d2413c9ce85b397788..5622813cc6fdf1fd8ac5a3450f8d354a11f572d9 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py

@@ -86,9 +86,5 @@ class PrettyDiff(Command):

changed_files=changed_files)

def _open_pretty_diff(self, file_path):

- if self._tool.platform.is_cygwin():

- assert file_path.endswith('.html')

- self._tool.executive.run_command(['cygstart', file_path])

- return

url = 'file://%s' % urllib.quote(file_path)

self._tool.user.open_url(url)

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py ('k') | no next file » | no next file with comments »