Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py

Issue 2799713002: Remove all support for cygwin in run-webkit-tests. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
index da9a1f2bf1eaf7344b2a8342eec6db36b90798ed..125b785f3520b1961cad698d7a6dc45fb3d7fcc2 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
@@ -92,7 +92,6 @@ class ServerProcess(object):
self._reset()
# See comment in imports for why we need the win32 APIs and can't just use select.
- # FIXME: there should be a way to get win32 vs. cygwin from platform_info.
self._use_win32_apis = sys.platform == 'win32'
def name(self):
@@ -154,9 +153,9 @@ class ServerProcess(object):
"""
# FIXME: Linux and Mac set the returncode to -signal.SIGINT if a
# subprocess is killed with a ctrl^C. Previous comments in this
- # routine said that supposedly Windows returns 0xc000001d, but that's not what
- # -1073741510 evaluates to. Figure out what the right value is
- # for win32 and cygwin here ...
+ # routine said that supposedly Windows returns 0xc000001d, but that's
+ # not what -1073741510 evaluates to. Figure out what the right value
+ # is for win32 here ...
if self._proc.returncode in (-1073741510, -signal.SIGINT):
raise KeyboardInterrupt

Powered by Google App Engine
This is Rietveld 408576698