Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2798123002: Remove crushed sprite resource and layer (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, twellington+watch_chromium.org, mikecase+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove crushed sprite resource and layer Crushed sprite resources and layers were only used for Contextual Search. CS no longer has a use for a the animated sprite, so this removes the crushed sprite resources and layers and replaces the CS use with a static icon. BUG=707001 Review-Url: https://codereview.chromium.org/2798123002 Cr-Commit-Position: refs/heads/master@{#462861} Committed: https://chromium.googlesource.com/chromium/src/+/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and fix my nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -1782 lines) Patch
M build/android/lint/suppressions.xml View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/java/res/drawable-mdpi/google_icon_sprite.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/google_icon_sprite.png View Binary file 0 comments Download
M chrome/android/java/res/layout/contextual_search_quick_action_icon_view.xml View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/java/res/raw/google_icon_sprite.json View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchIconSpriteControl.java View 1 chunk +0 lines, -117 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java View 1 4 chunks +47 lines, -83 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java View 4 chunks +3 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java View 5 chunks +49 lines, -144 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java View 5 chunks +0 lines, -104 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 7 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/compositor/layer/contextual_search_layer.h View 5 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/android/compositor/layer/contextual_search_layer.cc View 1 13 chunks +73 lines, -86 lines 0 comments Download
D chrome/browser/android/compositor/layer/crushed_sprite_layer.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/android/compositor/layer/crushed_sprite_layer.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/browser/android/compositor/layer/overlay_panel_layer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.h View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc View 4 chunks +27 lines, -70 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/android/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/ResourceManager.java View 6 chunks +2 lines, -39 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java View 1 chunk +0 lines, -292 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResourceLoader.java View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/android/javatests/src/org/chromium/ui/resources/sprites/CrushedSpriteResourceTest.java View 1 chunk +0 lines, -114 lines 0 comments Download
D ui/android/resources/crushed_sprite_resource.h View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/android/resources/crushed_sprite_resource.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M ui/android/resources/resource_manager.h View 3 chunks +1 line, -11 lines 0 comments Download
M ui/android/resources/resource_manager_impl.h View 4 chunks +0 lines, -27 lines 0 comments Download
M ui/android/resources/resource_manager_impl.cc View 3 chunks +0 lines, -107 lines 0 comments Download
M ui/android/resources/resource_manager_impl_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (14 generated)
Theresa
+dtrainor@ for resource manager stuff +mdjones@ - will you please look at the CS code ...
3 years, 8 months ago (2017-04-05 18:53:40 UTC) #4
mdjones
lgtm
3 years, 8 months ago (2017-04-05 22:58:14 UTC) #7
David Trainor- moved to gerrit
resource manager stuff lgtm.
3 years, 8 months ago (2017-04-06 00:07:05 UTC) #8
Theresa
+jbudorick@ for build/android/lint/suppressions.xml +isherman@ for deprecated histogram in histograms.xml
3 years, 8 months ago (2017-04-06 00:17:30 UTC) #10
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-06 00:46:35 UTC) #11
jbudorick
On 2017/04/06 00:17:30, Theresa wrote: > +jbudorick@ for build/android/lint/suppressions.xml > +isherman@ for deprecated histogram in ...
3 years, 8 months ago (2017-04-07 05:08:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798123002/20001
3 years, 8 months ago (2017-04-07 14:54:39 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:00:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ce5ab6e1b8c7f699c838b8086d4...

Powered by Google App Engine
This is Rietveld 408576698