Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2798123002: Remove crushed sprite resource and layer (Closed)
Patch Set: Rebase and fix my nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 </issue> 87 </issue>
88 <issue id="IconColors" severity="Error"> 88 <issue id="IconColors" severity="Error">
89 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/not ification_icon.png"/> 89 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/not ification_icon.png"/>
90 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/not ification_icon.png"/> 90 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/not ification_icon.png"/>
91 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/no tification_icon.png"/> 91 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/no tification_icon.png"/>
92 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/n otification_icon.png"/> 92 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/n otification_icon.png"/>
93 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/ notification_icon.png"/> 93 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/ notification_icon.png"/>
94 </issue> 94 </issue>
95 <issue id="IconDensities"> 95 <issue id="IconDensities">
96 <!-- The large assets below only include a few densities to reduce APK size. --> 96 <!-- The large assets below only include a few densities to reduce APK size. -->
97 <ignore regexp=": data_reduction_illustration.png, google_icon_sprite.png, p hysical_web_logo.png, physical_web_logo_anim1.png, physical_web_logo_anim2.png$" /> 97 <ignore regexp=": data_reduction_illustration.png, physical_web_logo.png, ph ysical_web_logo_anim1.png, physical_web_logo_anim2.png$"/>
98 <!-- crbug.com/457918 is tracking missing assets --> 98 <!-- crbug.com/457918 is tracking missing assets -->
99 <ignore regexp="chrome/android/java/res/drawable-xxhdpi"/> 99 <ignore regexp="chrome/android/java/res/drawable-xxhdpi"/>
100 <ignore regexp="chrome/android/java/res/drawable-xxxhdpi"/> 100 <ignore regexp="chrome/android/java/res/drawable-xxxhdpi"/>
101 <ignore regexp="chromecast/internal"/> 101 <ignore regexp="chromecast/internal"/>
102 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxhdpi"/> 102 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxhdpi"/>
103 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxxhdpi"/> 103 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxxhdpi"/>
104 <ignore regexp="content/public/android/java/res/drawable-xxhdpi"/> 104 <ignore regexp="content/public/android/java/res/drawable-xxhdpi"/>
105 <ignore regexp="content/public/android/java/res/drawable-xxxhdpi"/> 105 <ignore regexp="content/public/android/java/res/drawable-xxxhdpi"/>
106 <ignore regexp="ui/android/java/res/drawable-xxhdpi"/> 106 <ignore regexp="ui/android/java/res/drawable-xxhdpi"/>
107 <ignore regexp="ui/android/java/res/drawable-xxxhdpi"/> 107 <ignore regexp="ui/android/java/res/drawable-xxxhdpi"/>
108 </issue> 108 </issue>
109 <issue id="IconDipSize"> 109 <issue id="IconDipSize">
110 <ignore regexp="chromecast/internal"/> 110 <ignore regexp="chromecast/internal"/>
111 <ignore regexp="google_icon_sprite.png.*"/>
112 </issue> 111 </issue>
113 <issue id="IconDuplicates" severity="Error"> 112 <issue id="IconDuplicates" severity="Error">
114 <ignore regexp="chromecast/internal"/> 113 <ignore regexp="chromecast/internal"/>
115 </issue> 114 </issue>
116 <issue id="IconDuplicatesConfig" severity="Error"> 115 <issue id="IconDuplicatesConfig" severity="Error">
117 <ignore regexp="chromecast/internal"/> 116 <ignore regexp="chromecast/internal"/>
118 </issue> 117 </issue>
119 <issue id="IconLauncherShape" severity="Error"> 118 <issue id="IconLauncherShape" severity="Error">
120 <ignore regexp="chromecast/internal"/> 119 <ignore regexp="chromecast/internal"/>
121 </issue> 120 </issue>
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 </issue> 442 </issue>
444 <issue id="ViewConstructor" severity="ignore"/> 443 <issue id="ViewConstructor" severity="ignore"/>
445 <issue id="WrongCall" severity="ignore"/> 444 <issue id="WrongCall" severity="ignore"/>
446 <issue id="WrongConstant"> 445 <issue id="WrongConstant">
447 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 446 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
448 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> 447 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/>
449 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 448 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
450 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> 449 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/>
451 </issue> 450 </issue>
452 </lint> 451 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698