WebMouseEvent coordinates are now fractional & private

WebMouseEvent coordinates are now fractional & private

This CL moves WebMouseEvent coordinates (former (x,y) &
(globalX,globalY) into private members in the class, and
made them fractional in the /internal/ plumbing. There is
no change in behavior here since all coordinates
are truncated to integers on "input" to avoid regressions
(we will get rid of the truncation in a future CL).

BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2782893002
Cr-Commit-Position: refs/heads/master@{#462082}
Committed: https://chromium.googlesource.com/chromium/src/+/c51f3aabf26ae1d6852fbced8f44d5b26d2d0101

[mustaq, 2017-03-29 15:22:42]

Description was changed from

==========
Moved WebMouseEvent & WebTouchPoint coodinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to internal plumbing is that WebMouseEvent coordinates are now
fractional even though the fractions are not exposed to the web.

BUG=456625
==========

to

==========
Moved WebMouseEvent & WebTouchPoint coodinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to internal plumbing is that WebMouseEvent coordinates are now
fractional even though the fractions are not exposed to the web.

BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-29 15:24:58]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:25:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-03-29 15:25:43]

Description was changed from

==========
Moved WebMouseEvent & WebTouchPoint coodinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to internal plumbing is that WebMouseEvent coordinates are now
fractional even though the fractions are not exposed to the web.

BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Moved WebMouseEvent & WebTouchPoint coodinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to internal plumbing is that WebMouseEvent coordinates are now
fractional even though the fractions are not exposed to the web.

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-03-29 15:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:37:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mustaq, 2017-03-29 15:53:14]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:53:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 16:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:06:42]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mustaq, 2017-03-29 16:43:03]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:43:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 16:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:59:33]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[mustaq, 2017-03-29 19:04:54]

Description was changed from

==========
Moved WebMouseEvent & WebTouchPoint coodinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to internal plumbing is that WebMouseEvent coordinates are now
fractional even though the fractions are not exposed to the web.

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Moved WebMouseEvent & WebTouchPoint coordinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to /internal/ plumbing is that WebMouseEvent coordinates are now
fractional (the fractions are not exposed to the web).

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-29 19:21:33]

Description was changed from

==========
Moved WebMouseEvent & WebTouchPoint coordinates to a common place.

WebPointerProperties now holds the coordinates. One functional change it
does to /internal/ plumbing is that WebMouseEvent coordinates are now
fractional (the fractions are not exposed to the web).

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unified web pointer coordinates, made WebMouseEvent coordinates fractional

Moved WebMouseEvent and WebTouchPoint coordinates to WebPointerProperties.
The only functional change here that WebMouseEvent coordinates (former
(x,y) & (globalX,globalY) coordinates) are now fractional but this change
affects /internal/ plumbing only (not exposed to the web).

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-29 19:22:12]

Description was changed from

==========
Unified web pointer coordinates, made WebMouseEvent coordinates fractional

Moved WebMouseEvent and WebTouchPoint coordinates to WebPointerProperties.
The only functional change here that WebMouseEvent coordinates (former
(x,y) & (globalX,globalY) coordinates) are now fractional but this change
affects /internal/ plumbing only (not exposed to the web).

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unified web pointer coordinates, made WebMouseEvent coordinates fractional

Moved WebMouseEvent and WebTouchPoint coordinates to WebPointerProperties.
The only functional change here is that WebMouseEvent coordinates (former
(x,y) & (globalX,globalY) coordinates) are now fractional but this change
affects /internal/ plumbing only (not exposed to the web).

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-29 19:30:36]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 19:31:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-03-29 19:31:46]

The CQ bit was unchecked by mustaq@chromium.org

[mustaq, 2017-03-29 19:47:48]

Description was changed from

==========
Unified web pointer coordinates, made WebMouseEvent coordinates fractional

Moved WebMouseEvent and WebTouchPoint coordinates to WebPointerProperties.
The only functional change here is that WebMouseEvent coordinates (former
(x,y) & (globalX,globalY) coordinates) are now fractional but this change
affects /internal/ plumbing only (not exposed to the web).

BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Made WebMouseEvent coordinates fractional

WebMouseEvent coordinates (former (x,y) & (globalX,globalY)
coordinates) are now fractional in the /internal/ plumbing.
All mouse events fired to JS remain non-fractional as before,
so we don't expect any major regression. However, some
"users" of the coordinates now effectively defer
rounding-to-int until DOM events are created, so there is
a slight chance that internal assumptions could be affected.
If that happens, the fix should be easy: typecasting to
ints.

The new fields are named to match WebTouchPoint coordinates
so that in near future, moving WebMouseEvent & WebTouchPoint
coordinates to WebPointerProperties will be easy. We are
holding this change back now to ease fighting possible
regressions.


BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-29 19:48:51]

mustaq@chromium.org changed reviewers:
+ dtapuska@chromium.org

[mustaq, 2017-03-29 19:48:52]

ptal

[dtapuska, 2017-03-29 20:19:15]

https://codereview.chromium.org/2782893002/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebMouseEvent.h (right):

https://codereview.chromium.org/2782893002/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:24: WebFloatPoint position;
I think we really should move these to be accessors like

positionInScreen()
and
positionInView()

that will go a long way in making this class struct like and more OO like.

[mustaq, 2017-03-30 20:56:35]

Description was changed from

==========
Made WebMouseEvent coordinates fractional

WebMouseEvent coordinates (former (x,y) & (globalX,globalY)
coordinates) are now fractional in the /internal/ plumbing.
All mouse events fired to JS remain non-fractional as before,
so we don't expect any major regression. However, some
"users" of the coordinates now effectively defer
rounding-to-int until DOM events are created, so there is
a slight chance that internal assumptions could be affected.
If that happens, the fix should be easy: typecasting to
ints.

The new fields are named to match WebTouchPoint coordinates
so that in near future, moving WebMouseEvent & WebTouchPoint
coordinates to WebPointerProperties will be easy. We are
holding this change back now to ease fighting possible
regressions.


BUG=456625,508283
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Made WebMouseEvent coordinates fractional internally.

WebMouseEvent coordinates (former (x,y) & (globalX,globalY)
coordinates) are now fractional in the /internal/ plumbing.
There is no change in behavior here since all coordinates
are truncated to integers on set to avoid regressions---we
will get rid of the truncation in a future CL.


BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-30 20:56:35]

mustaq@chromium.org changed reviewers:
+ bokan@chromium.org

[mustaq, 2017-03-30 21:01:14]

Description was changed from

==========
Made WebMouseEvent coordinates fractional internally.

WebMouseEvent coordinates (former (x,y) & (globalX,globalY)
coordinates) are now fractional in the /internal/ plumbing.
There is no change in behavior here since all coordinates
are truncated to integers on set to avoid regressions---we
will get rid of the truncation in a future CL.


BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
WebMouseEvent coordinates are now fractional & private

This CL moves WebMouseEvent coordinates (former (x,y) &
(globalX,globalY) into private members in the class, and
made them fractional in the /internal/ plumbing. There is
no change in behavior here since all coordinates
are truncated to integers on "input" to avoid regressions
(we will get rid of the truncation in a future CL).

BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mustaq, 2017-03-30 21:01:35]

ptal

https://codereview.chromium.org/2782893002/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebMouseEvent.h (right):

https://codereview.chromium.org/2782893002/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:24: WebFloatPoint position;
On 2017/03/29 20:19:15, dtapuska wrote:
> I think we really should move these to be accessors like
> 
> positionInScreen()
> and
> positionInView()
> 
> that will go a long way in making this class struct like and more OO like.
> 

Done, all done, phew!

[mustaq, 2017-03-30 21:14:55]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 21:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:05:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:05:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dtapuska, 2017-03-31 14:04:19]

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
File
content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
(right):

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc:258:
gfx::PointF mouse_point(mouse_event.positionInWidget().x,
I think this can be mouse_event.poisitionInWidget()

there is an implicit conversion from WebFloatPoint -> gfx::PointF
(https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebFl...)

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
File content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
(right):

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc:180:
position_ = gfx::PointF(mouse_event.positionInWidget().x,
same

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:510:
result.x = temp.positionInWidget().x;
We should probably fix WebGestureEvent next eh?

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/WebMouseEvent.cpp (right):

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/WebMouseEvent.cpp:21:
m_positionInWidget(WebFloatPoint(gestureEvent.x, gestureEvent.y)),
This is odd. Do you require the extra WebFloatPoint here (and the line below)

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/WebMouseEvent.cpp:46:
floor((m_positionInWidget.x / m_frameScale) + m_frameTranslate.x);
Can we add a comment why we are taking the floor? Referencing the bug #.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
(right):

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp:395:
webMouseEvent2.setPositionInWidget(0, 140);
This looks wrong. Only the y is getting adjusted.. probably should have x from
the other event.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebMouseEvent.h (right):

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:51:
m_positionInWidget(floor(position.x), floor(position.y)),
Can we add a comment regarding the floor... referencing an open bug?

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:86: m_positionInWidget =
WebFloatPoint(floor(x), floor(y));
Same as why we are doing the floor...

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:91: m_positionInScreen =
WebFloatPoint(floor(x), floor(y));
here too :-)

[mustaq, 2017-03-31 15:50:32]

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
File
content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
(right):

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc:258:
gfx::PointF mouse_point(mouse_event.positionInWidget().x,
On 2017/03/31 14:04:18, dtapuska wrote:
> I think this can be mouse_event.poisitionInWidget()
> 
> there is an implicit conversion from WebFloatPoint -> gfx::PointF
>
(https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebFl...)

Done.

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
File content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
(right):

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc:180:
position_ = gfx::PointF(mouse_event.positionInWidget().x,
On 2017/03/31 14:04:18, dtapuska wrote:
> same

Done.

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2782893002/diff/140001/content/browser/render...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:510:
result.x = temp.positionInWidget().x;
On 2017/03/31 14:04:18, dtapuska wrote:
> We should probably fix WebGestureEvent next eh?

Added a TODO in WebGestureEvent.h .

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/WebMouseEvent.cpp (right):

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/WebMouseEvent.cpp:21:
m_positionInWidget(WebFloatPoint(gestureEvent.x, gestureEvent.y)),
On 2017/03/31 14:04:18, dtapuska wrote:
> This is odd. Do you require the extra WebFloatPoint here (and the line below)

Thanks for the catch, done.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/WebMouseEvent.cpp:46:
floor((m_positionInWidget.x / m_frameScale) + m_frameTranslate.x);
On 2017/03/31 14:04:18, dtapuska wrote:
> Can we add a comment why we are taking the floor? Referencing the bug #.

Added a comment in the class header.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
(right):

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp:395:
webMouseEvent2.setPositionInWidget(0, 140);
On 2017/03/31 14:04:18, dtapuska wrote:
> This looks wrong. Only the y is getting adjusted.. probably should have x from
> the other event.

Done.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebMouseEvent.h (right):

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:51:
m_positionInWidget(floor(position.x), floor(position.y)),
On 2017/03/31 14:04:18, dtapuska wrote:
> Can we add a comment regarding the floor... referencing an open bug?

Added a class comment above.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:86: m_positionInWidget =
WebFloatPoint(floor(x), floor(y));
On 2017/03/31 14:04:18, dtapuska wrote:
> Same as why we are doing the floor...

Ditto.

https://codereview.chromium.org/2782893002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:91: m_positionInScreen =
WebFloatPoint(floor(x), floor(y));
On 2017/03/31 14:04:18, dtapuska wrote:
> here too :-)

Ditto too :-)

[mustaq, 2017-03-31 15:50:46]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:51:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 16:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:04:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mustaq, 2017-03-31 16:19:46]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:20:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:56:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bokan, 2017-03-31 19:07:43]

lgtm % comment

https://codereview.chromium.org/2782893002/diff/200001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebMouseEvent.h (right):

https://codereview.chromium.org/2782893002/diff/200001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:111: // Widget coordinates,
i.e., the coordinates in Chromium's RenderView
this should be "coordinates in Chromium's *RenderWidget*" since there's only one
RenderView per-page but we might be relative to a widget inside the RenderView
(e.g. Plugin, OOPIF, etc).

[mustaq, 2017-03-31 20:44:53]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[mustaq, 2017-03-31 20:45:23]

https://codereview.chromium.org/2782893002/diff/200001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebMouseEvent.h (right):

https://codereview.chromium.org/2782893002/diff/200001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebMouseEvent.h:111: // Widget coordinates,
i.e., the coordinates in Chromium's RenderView
On 2017/03/31 19:07:43, bokan wrote:
> this should be "coordinates in Chromium's *RenderWidget*" since there's only
one
> RenderView per-page but we might be relative to a widget inside the RenderView
> (e.g. Plugin, OOPIF, etc).

Done.

[commit-bot: I haz the power, 2017-03-31 20:45:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-03-31 21:02:17]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 21:03:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-03-31 21:07:51]

The CQ bit was unchecked by mustaq@chromium.org

[mustaq, 2017-03-31 21:37:47]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 21:38:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 23:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 23:36:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mustaq, 2017-04-03 17:49:34]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 17:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2017-04-03 17:59:30]

Patchset #16 (id:300001) has been deleted

[dtapuska, 2017-04-03 19:27:59]

lgtm % nit

https://codereview.chromium.org/2782893002/diff/320001/content/browser/render...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2782893002/diff/320001/content/browser/render...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:121: // Flip
y conditinally.
s/conditinally/conditionally

[mustaq, 2017-04-03 19:42:41]

mustaq@chromium.org changed reviewers:
+ creis@chromium.org, rbyers@chromium.org

[mustaq, 2017-04-03 19:42:43]

rbyerscreis@chromium.org: Please review changes in 
  third_party/WebKit/public/platform/
  content/shell/test_runner/

creis@chromium.org: Please review changes in 
  content/browser/
  content/public/
  content/renderer/

https://codereview.chromium.org/2782893002/diff/320001/content/browser/render...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2782893002/diff/320001/content/browser/render...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:121: // Flip
y conditinally.
On 2017/04/03 19:27:58, dtapuska wrote:
> s/conditinally/conditionally

Done.

[mustaq, 2017-04-03 19:43:53]

mustaq@chromium.org changed reviewers:
+ cjgrant@chromium.org

[mustaq, 2017-04-03 19:43:54]

cjgrant@chromium.org: Please review changes in 
  chrome/browser/android/vr_shell/

[mustaq, 2017-04-03 19:43:57]

cjgrant@chromium.org: Please review changes in 
  chrome/browser/android/vr_shell/

[commit-bot: I haz the power, 2017-04-03 19:49:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:49:37]

Dry run: This issue passed the CQ dry run.

[cjgrant, 2017-04-03 20:31:33]

lgtm

[Charlie Reis, 2017-04-03 20:56:15]

content/ LGTM

[mustaq, 2017-04-03 21:06:34]

mustaq@chromium.org changed reviewers:
+ jochen@chromium.org

[mustaq, 2017-04-03 21:06:35]

jochen@chromium.org: Please review changes in
  chrome/browser/
  chrome/renderer/plugins/chrome_plugin_placeholder.cc

dcheng@chromium.org: Please review changes in
  content/common/input/input_param_traits_unittest.cc

[mustaq, 2017-04-04 13:51:13]

rbyers@chromium.org: Please review changes in 
  third_party/WebKit/public/platform/
  content/shell/test_runner/

(Just realized my copy-paste mistake in #msg59 above.)

[Rick Byers, 2017-04-04 19:10:16]

WebKit/public LGTM

Rest of WebKit RS LGTM based on other reviews

[Rick Byers, 2017-04-04 19:13:00]

Sorry, content/shell/test_runner also LGTM

BTW I love the clarity in naming here.  "positionInScreen" and
"positionInWidget" are so much clearer than globalX/globaY, x/y - thanks!

[mustaq, 2017-04-04 19:20:32]

mustaq@chromium.org changed reviewers:
+ dcheng@chromium.org

[mustaq, 2017-04-04 19:20:33]

dcheng@chromium.org: Please review changes in
  content/common/input/input_param_traits_unittest.cc

[dcheng, 2017-04-04 19:42:23]

rs lgtm for param traits unittest changes

[jochen (gone - plz use gerrit), 2017-04-05 08:23:45]

lgtm

[mustaq, 2017-04-05 13:52:23]

The CQ bit was checked by mustaq@chromium.org

[mustaq, 2017-04-05 13:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
jochen@chromium.org, rbyers@chromium.org, dcheng@chromium.org,
creis@chromium.org, dtapuska@chromium.org, cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2782893002/#ps340001
(title: "Rebased, fixed a comment in web_input_event_builders_mac.mm")

[commit-bot: I haz the power, 2017-04-05 13:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:43:17]

CQ is committing da patch.

Bot data: {"patchset_id": 340001, "attempt_start_ts": 1491400343882550,
"parent_rev": "9b658f03a5e60309e3e430810ecfaec6886cbadb", "commit_rev":
"c51f3aabf26ae1d6852fbced8f44d5b26d2d0101"}

[commit-bot: I haz the power, 2017-04-05 15:44:10]

Description was changed from

==========
WebMouseEvent coordinates are now fractional & private

This CL moves WebMouseEvent coordinates (former (x,y) &
(globalX,globalY) into private members in the class, and
made them fractional in the /internal/ plumbing. There is
no change in behavior here since all coordinates
are truncated to integers on "input" to avoid regressions
(we will get rid of the truncation in a future CL).

BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
WebMouseEvent coordinates are now fractional & private

This CL moves WebMouseEvent coordinates (former (x,y) &
(globalX,globalY) into private members in the class, and
made them fractional in the /internal/ plumbing. There is
no change in behavior here since all coordinates
are truncated to integers on "input" to avoid regressions
(we will get rid of the truncation in a future CL).

BUG=456625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2782893002
Cr-Commit-Position: refs/heads/master@{#462082}
Committed:
https://chromium.googlesource.com/chromium/src/+/c51f3aabf26ae1d6852fbced8f44...
==========

[commit-bot: I haz the power, 2017-04-05 15:44:13]

Committed patchset #17 (id:340001) as
https://chromium.googlesource.com/chromium/src/+/c51f3aabf26ae1d6852fbced8f44...